Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp686098ybb; Thu, 28 Mar 2019 10:09:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzk9TorZamsiJeINnvqQDfX6Q8d8hF7Y1bX6uZ1RQayimbVIIuIi9wNayhFtRIB9uxWx2g3 X-Received: by 2002:a17:902:b94a:: with SMTP id h10mr16207292pls.82.1553792956369; Thu, 28 Mar 2019 10:09:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553792956; cv=none; d=google.com; s=arc-20160816; b=Tw/tZYKZVvM5Qy1uayPR9skQyUjinr4MF8vRTsMgIal9YcETlCoylaKJzQQiihn6au jBNWM7zTj2bXQ8n/34/0G+OG1eVBN2qmQI1vsUcNwjo3c+SW2jQWA7OMqdwBPWXWbx0q TNmrcF7bPfIQOTgIP6K2r5aTCIGSqNA+rHlUxyVB1fRGfB764BOnqWbYY6VLnXkLtShy KdL0SMg+B4TCYIG7u7pojUE9rLeZfwi3aslpwK0WL6+bbbe19aBUIbMsnzJmfagxLXem thq9QUv2JNb4vlGphTQ9CHI8PDDP15qjCTHgxzfoxQZdALDaC/2yrZckEIlyCapdSrDp rTvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Xo5m4lzWljKFa45FWhqQys+N1R7vTTwn+vwGeAbfBus=; b=J8pOCHwwZRcjGpEawAxaXPBw+ZyoI87bjzNq0+k/zJ6a/E+qa5phT1hrs8Fvg+eSTf P5QftJOlh+ajyjaP1fpWDacXpcEcVsmeFp4/5k46Sjoq4m/hS6ophR5jErOwnyXqdT2z gdqbkvizP0FCbAr6091tKoO37887hMmyNJ+ZVFkfYacu2n5Ah6d5buvi3xdK1LW+Doxh jL6duUoMOD1EBgVc30KeJ7nDP+G23I+8IYtOSd+nWdRLMTv2Nk/Yu2Rcpf+1u/MuQj6O UvOkefNtVlYHG2v4QAzuS2s0GLBXU2dGOAW8JlQKiaWYmwUaShCu+Sh5E3P26fbPutPd cpCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@brauner.io header.s=google header.b=Po6sn+Uw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w10si21737137plq.328.2019.03.28.10.09.00; Thu, 28 Mar 2019 10:09:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@brauner.io header.s=google header.b=Po6sn+Uw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbfC1RHF (ORCPT + 99 others); Thu, 28 Mar 2019 13:07:05 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:42071 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbfC1RHF (ORCPT ); Thu, 28 Mar 2019 13:07:05 -0400 Received: by mail-ed1-f65.google.com with SMTP id x61so12212185edc.9 for ; Thu, 28 Mar 2019 10:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Xo5m4lzWljKFa45FWhqQys+N1R7vTTwn+vwGeAbfBus=; b=Po6sn+Uw832pyRVp4TvXPg/SODeW16fvejyM7SGXFwIhkaQOSJcy+I0Hugn26Oq1B+ bR3r8kdJSv/6w3JqxhWAcy+lQzYjpQFS7uSUSgGyb5CVdpNGUK5L7XUscwDlHgklwgtS 6vYqrpHBTvSCIgqTrbVftQs4nxvKZVHXHfga2wfBtEkyWM+HlCc+92xH1K322ePgnbab iSGQAYWSpMqXNitwqZz7euC89QjgFMyy27C0Dco2+mGEmS5euk/F3UfcuOUVllwJxzox whdE7eh4uzmjWXaK8iLTYXXXyPcVln7hPPYCBWd8oxf2s8b97qPWq19wtgORwNojoMeT poLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xo5m4lzWljKFa45FWhqQys+N1R7vTTwn+vwGeAbfBus=; b=oOWcIgrLxV81uDHemjNw73Lz0qCyIMCb82W504z9ioi28tbfoD9g+Yhce0m72D7Ihh l+40kOsQH54244S5D1v1TIhfw3jQk8CbK5eII5MfSwUFF6TErL978HeNa5jt0kL1EjDf 5qWPmaNR5zbUklnnactP4t51YwLvGdeZaV7aAzcsg4UoRpMTVapSsLW8sCi7HVeh2x7H TPAfKzKlnzPT8SW4XlOfttM9ntQ8EYrajZrPyFIevzmnYVxbhxBGPDRZIk91KrqxP15r RiZncjuDifjPvCGiq4mYYCw+Ku9R7riFJRLamLcpIvCY6YoexJuNZarew5fFqSAhTdfm fIUw== X-Gm-Message-State: APjAAAWA5V/sCmqrHussUCScfCh/LZ/sy8G4cRi/6n35ilRX9Eth1Cdj hi5vOJ5UP4u3May+x+zVzNoKEw== X-Received: by 2002:aa7:c891:: with SMTP id p17mr13103876eds.183.1553792823150; Thu, 28 Mar 2019 10:07:03 -0700 (PDT) Received: from brauner.io ([2a02:8109:b6bf:d24a:b136:35b0:7c8c:280a]) by smtp.gmail.com with ESMTPSA id a28sm1341486edm.91.2019.03.28.10.07.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 28 Mar 2019 10:07:02 -0700 (PDT) Date: Thu, 28 Mar 2019 18:07:01 +0100 From: Christian Brauner To: Joel Fernandes Cc: Jonathan Kowalski , Jann Horn , Konstantin Khlebnikov , Andy Lutomirski , David Howells , "Serge E. Hallyn" , "Eric W. Biederman" , Linux API , linux-kernel , Arnd Bergmann , Kees Cook , Alexey Dobriyan , Thomas Gleixner , Michael Kerrisk-manpages , "Dmitry V. Levin" , Andrew Morton , Oleg Nesterov , Nagarathnam Muthusamy , Aleksa Sarai , Al Viro , Daniel Colascione Subject: Re: [PATCH 2/4] pid: add pidfd_open() Message-ID: <20190328170700.hx5ywsij77wawmon@brauner.io> References: <20190327162147.23198-1-christian@brauner.io> <20190327162147.23198-3-christian@brauner.io> <20190327213404.pv4wqtkjbufkx36u@brauner.io> <20190327222543.huugotqcew6jyytv@brauner.io> <20190328103813.eogszrqbitw3e7k7@brauner.io> <533075A9-A6CF-4549-AFC8-B90505B198FD@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <533075A9-A6CF-4549-AFC8-B90505B198FD@joelfernandes.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 28, 2019 at 12:59:46PM -0400, Joel Fernandes wrote: > > > On March 28, 2019 6:38:15 AM EDT, Christian Brauner wrote: > >> All that said, thanks for the work on this once again. My intention > >is > >> just that we don't end up with an API that could have been done > >better > >> and be cleaner to use for potential users in the coming years. > > > >Thanks for your input on all of this. I still don't find multiplexers > >in > >the style of seccomp()/fsconfig()/keyctl() to be a problem since they > >deal with a specific task. They are very much different from ioctl()s > >in > >that regard. But since Joel, you, and Daniel found the pidctl() > >approach > >not very nice I dropped it. The interface needs to be satisfactory for > >all of us especially since Android and other system managers will be > >the > >main consumers. > >So let's split this into pidfd_open(pid_t pid, unsigned int flags) > >which > >allows to cleanly get pidfds independent procfs and do the translation > >to procpidfds in an ioctl() as we've discussed in prior threads. This > >should also accommodate comments and ideas from Andy and Jann. > >I'm coding this up now. > > This sounds quite sensible to me. Thanks! Thanks! I have it ready and hope to send it out later today. Christian