Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553648174-24913-1-git-send-email-v.mayatskih@gmail.com>
 <20190327164914.GE27283@stefanha-x1.localdomain> <CAGF4SLiKv06rzuGprfpWg-EOi8y+DW+cTybCkoT_9OoE+y8tcQ@mail.gmail.com>
 <20190328163647.GE18536@stefanha-x1.localdomain>
In-Reply-To: <20190328163647.GE18536@stefanha-x1.localdomain>
From:   Vitaly Mayatskih <v.mayatskih@gmail.com>
Date:   Thu, 28 Mar 2019 13:08:36 -0400
Message-ID: <CAGF4SLiZxXcWskZXmGbwO11MnwyMAK_Bpbn0ugZzK6jSMHdiog@mail.gmail.com>
Subject: Re: [PATCH] vhost: zero vhost_vsock memory on allocation
To:     Stefan Hajnoczi <stefanha@redhat.com>
Cc:     Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 28, 2019 at 12:36 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:

> vsock->hash is only read if vsock->guest_cid has already been set and
> hence vsock->hash has been initialized too.  I don't see where the
> problem is.
>
> Was your tree missing commit a72b69dc083a931422cc8a5e33841aff7d5312f2
> ("vhost/vsock: fix uninitialized vhost_vsock->guest_cid")?
>
> Are you sure the crash can be reproduced on linux.git/master?

You are right: we hit it on 4.14.91 while the guest_cid fix was
backported in 4.14.93.
Thus not a real issue. Sorry for confusion, vhost is something still new to me.

> Sounds good.  Please send a v2 that also removes the explicit zero
> initialization since it's no longer needed with zalloc.

I changed my mind, all the rest is initialized explicitly, let's keep
it that way.
Will send the patch shortly.

-- 
wbr, Vitaly