Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Haiyang Zhang <haiyangz@microsoft.com>
To:     David Miller <davem@davemloft.net>
CC:     "sashal@kernel.org" <sashal@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "olaf@aepfle.de" <olaf@aepfle.de>, vkuznets <vkuznets@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after
 tx_disable
Thread-Topic: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after
 tx_disable
Thread-Index: AQHU5ZrtrFq7C3HnrUW1n+cygRgMW6Yha+MAgAAAo2A=
Date:   Thu, 28 Mar 2019 19:27:39 +0000
Message-ID: <DM6PR21MB1337D7CB7707022BEE58C86BCA590@DM6PR21MB1337.namprd21.prod.outlook.com>
References: <20190328191637.6698-1-haiyangz@linuxonhyperv.com>
 <20190328.122214.1269115693598269959.davem@davemloft.net>
In-Reply-To: <20190328.122214.1269115693598269959.davem@davemloft.net>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=haiyangz@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-03-28T19:27:37.6191497Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=0e3eb8f8-f9a5-433a-b17f-130d89a4fe06;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic
x-originating-ip: [96.61.92.94]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 076ef0b7-8bae-4cba-b25b-08d6b3b3710d
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:DM6PR21MB1146;
x-ms-traffictypediagnostic: DM6PR21MB1146:
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=haiyangz@microsoft.com; 
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs: <DM6PR21MB1146001271FECC780BC25504CA590@DM6PR21MB1146.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 0990C54589
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(39860400002)(136003)(396003)(376002)(346002)(189003)(199004)(13464003)(102836004)(54906003)(316002)(10090500001)(5660300002)(81166006)(66066001)(22452003)(305945005)(11346002)(486006)(476003)(446003)(229853002)(25786009)(81156014)(86612001)(52536014)(33656002)(6246003)(71200400001)(71190400001)(105586002)(74316002)(106356001)(7696005)(2906002)(256004)(86362001)(53936002)(97736004)(478600001)(6916009)(99286004)(6116002)(68736007)(6506007)(55016002)(8676002)(26005)(14454004)(8990500004)(10290500003)(7736002)(76176011)(8936002)(3846002)(186003)(53546011)(9686003)(4326008)(6436002)(26123001)(142933001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR21MB1146;H:DM6PR21MB1337.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: IVTmY7OiBUD0VBv7VcZhxqTFuLHzyIq6zh9Ic6nHkT0h+ge31P0Ou32YuR9hR+ZZJe58AybwBXIGCwJZeaDNuKCZIXzDpHuMceVcaNBmJfUtdTfJOUOyITh7MHPKYWAfs7oqfXYBw58qaEV4cwETix61d9cxYiELfH54czYcnOoo3//lXbHimnrMKqBIlEl6u40d1Etjke8u9TZRoStrFjQutyM7jXW3l7+HNktGX+3id84UNRjIdKdl8julOIsc39ZXXIJtX7HQcbUcnnzEecBMWYtYQubAC+tZqUqhprimGRmkjN29M7hL05PCBiQZNtyqGrEox4kgxPLs4ACsmnOpCANhUV05H5+wdGI/2V9M7CRF4KvgQJyigv2ArPvJ/o/s098IebL8dSecz/L7p7TGFNoRZx1JIok4A0b3g80=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 076ef0b7-8bae-4cba-b25b-08d6b3b3710d
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2019 19:27:39.6084
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR21MB1146
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: linux-hyperv-owner@vger.kernel.org <linux-hyperv-
> owner@vger.kernel.org> On Behalf Of David Miller
> Sent: Thursday, March 28, 2019 3:22 PM
> To: haiyangz@linuxonhyperv.com
> Cc: sashal@kernel.org; linux-hyperv@vger.kernel.org; Haiyang Zhang
> <haiyangz@microsoft.com>; KY Srinivasan <kys@microsoft.com>; Stephen
> Hemminger <sthemmin@microsoft.com>; olaf@aepfle.de; vkuznets
> <vkuznets@redhat.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after
> tx_disable
>=20
> From: Haiyang Zhang <haiyangz@linuxonhyperv.com>
> Date: Thu, 28 Mar 2019 19:16:37 +0000
>=20
> > From: Haiyang Zhang <haiyangz@microsoft.com>
> >
> > After queue stopped, the wakeup mechanism may wake it up again when
> > ring buffer usage is lower than a threshold. This may cause send path
> > panic on NULL pointer when we stopped all tx queues in netvsc_detach
> > and start removing the netvsc device.
> >
> > This patch fix it by adding a tx_disable flag to prevent unwanted
> > queue wakeup.
> >
> > Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> > Reported-by: Mohammed Gamal <mgamal@redhat.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
>=20
> Still need to fix the inline issues I mentioned in v1.

I will fix the inline issues.=20

The haiyangz@linuxonhyperv.com cannot receive emails.=20
My regular email is in the reply-to: field.=20
Also, linuxonhyperv.com is being replaced by a new system soon.

Thanks.
- Haiyang