Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190325194220.5873-1-helgaas@kernel.org> <9f4e9d19-8d82-bff0-a627-f82757d1da59@redhat.com>
In-Reply-To: <9f4e9d19-8d82-bff0-a627-f82757d1da59@redhat.com>
From:   Bjorn Helgaas <bhelgaas@google.com>
Date:   Thu, 28 Mar 2019 15:40:05 -0500
Message-ID: <CAErSpo4dzRbVVN40x-1PFmCDMAB81=75r+kAuoDgDGXZHtQRQw@mail.gmail.com>
Subject: Re: [PATCH] vfio: Use dev_printk() when possible
To:     Auger Eric <eric.auger@redhat.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        kvm@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 5:00 PM Auger Eric <eric.auger@redhat.com> wrote:
>
> Hi Bjorn,
> On 3/25/19 8:42 PM, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>

> > --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> > +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> > @@ -89,7 +89,8 @@ static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)
> >       } while ((pcs_value & MDIO_CTRL1_RESET) && --count);
> >
> >       if (pcs_value & MDIO_CTRL1_RESET)
> > -             pr_warn("%s XGBE PHY reset timeout\n", __func__);
> > +             dev_warn(&vdev->device, "%s XGBE PHY reset timeout\n",
> vdev->device

Indeed, thank you!

> > @@ -63,7 +63,7 @@ static int vfio_platform_acpi_probe(struct vfio_platform_device *vdev,
> >
> >       adev = ACPI_COMPANION(dev);
> >       if (!adev) {
> > -             pr_err("VFIO: ACPI companion device not found for %s\n",
> > +             dev_err(dev, "VFIO: ACPI companion device not found for %s\n",
> >                       vdev->name);
> nit: for VFIO platform devices vdev->name and dev_name(dev) are the
> same. But for amba devices they are different I think so it looks
> sensible to keep both names at the moment.

OK, I'll keep this hunk as-is.

Bjorn