Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Mar 2019 17:02:57 -0700 (PDT)
Message-Id: <20190328.170257.1630360267676400395.davem@davemloft.net>
To:     maxime.chevallier@bootlin.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com,
        gregory.clement@bootlin.com, miquel.raynal@bootlin.com,
        nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com,
        linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
        andrew@lunn.ch
Subject: Re: [PATCH net-next] net: mvneta: Add 2500BaseT support
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190327163107.11642-1-maxime.chevallier@bootlin.com>
References: <20190327163107.11642-1-maxime.chevallier@bootlin.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: Wed, 27 Mar 2019 17:31:06 +0100

> Some PHYs will use the 2500BaseX PHY_INTERFACE_MODE when being linked
> with a partner using 2.5GBaseT.
> 
> Since we can't autonegotiate this speed between the MAC and the PHY, we
> need to have the proper comphy support enabled, to make sure we can
> safely advertise 2.5G and 1G in BaseT and be able to switch between both
> corresponding PHY interface modes. This is now possible since comphy
> support was added to this driver.
> 
> This commit adds the 2500BaseT mode to the list of supported modes when
> using 2500BaseX, and was tested on a setup with an Armada385 and a
> 88E2010 PHY, both with and without the comphy node in the DT.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Applied.