Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1071918ybb;
        Thu, 28 Mar 2019 19:06:23 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxQkJIFYxKq0mzS4ywCLU/Y/GEfGZN+/dJX64dYDZuTyy1bKgiObkYIZNYRZ893oAJluuV0
X-Received: by 2002:a63:fb16:: with SMTP id o22mr42204391pgh.209.1553825183623;
        Thu, 28 Mar 2019 19:06:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1553825183; cv=none;
        d=google.com; s=arc-20160816;
        b=Oxrxp/OShHwJtwt5FtzH3y3YTUFdHVZMOGOJswaAI5hwH3F2ETPZym39Yph1CgB3rr
         yBVEWhqjtodbUOhJf4n7C3cmPfQ0YnDJ861ELtmxAN9dC4g2nx0baPfcntB2e2lo0/OA
         wlolLZIY5f4iLxX8DNrvmbhgMcdXPazYw5WZA2/tnV2U5B7ochj0ka2cbVXNFix8AeiU
         +If8js3UG6sneEjjJuBg3S7AkG9mvAZJDAJoPhBJbOhl2KA0jAy24U3VqcuAAwsRiJL0
         2waUESYaOed1+imLhjVLxApz7AslgDFQBtKFp8GaFo01wiygHcLALcoUqtWW25BmnaBl
         sqCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=+1O9YpiNfEVCCc+AeXkWqW7U0Khy1QDft89NTnXa5GY=;
        b=o0uVByO5YxMag0y11Qgr083KZcYziqIS97EGO1+e+l4wERHRSTj+aGdYbaWVlglhpO
         nPpMT+WJq1WXGBTFp7kJJyTfLdfphgSOuuTQGQOl0xsl394yEbnh1WfIVV2TkVj5jXAt
         zK9N7wVS73cTrEyQqUngiHN0Kmgzzc+eUpe2MpW1wqlmXkZDFFVWQ7v0qcZMueX/F5ii
         amsDHeYg9pBvBxxuxn96X/D92g64eLprDY27JYwKSMR8D835/HRzk2Q5Xhc0nNmq84xJ
         usXLSjVkU8r8MFFSwzcBpKJYgOod/A37Sh21Z62XqHEV2tXnF2yAHPDA7KzaYbXLZIQy
         n37g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=FRvCg0fM;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id h7si600277pfb.167.2019.03.28.19.06.07;
        Thu, 28 Mar 2019 19:06:23 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=FRvCg0fM;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728587AbfC2CFY (ORCPT <rfc822;carmate383@gmail.com>
        + 99 others); Thu, 28 Mar 2019 22:05:24 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:12214 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727938AbfC2CFY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Mar 2019 22:05:24 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c9d7d650000>; Thu, 28 Mar 2019 19:05:25 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 28 Mar 2019 19:05:22 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 28 Mar 2019 19:05:22 -0700
Received: from [10.110.48.28] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 29 Mar
 2019 02:05:21 +0000
Subject: Re: [PATCH v2 07/11] mm/hmm: add default fault flags to avoid the
 need to pre-fill pfns arrays.
To:     Jerome Glisse <jglisse@redhat.com>, Ben Skeggs <bskeggs@redhat.com>
CC:     Ira Weiny <ira.weiny@intel.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>
References: <20190328221203.GF13560@redhat.com>
 <555ad864-d1f9-f513-9666-0d3d05dbb85d@nvidia.com>
 <20190328223153.GG13560@redhat.com>
 <768f56f5-8019-06df-2c5a-b4187deaac59@nvidia.com>
 <20190328232125.GJ13560@redhat.com>
 <d2008b88-962f-b7b4-8351-9e1df95ea2cc@nvidia.com>
 <20190328164231.GF31324@iweiny-DESK2.sc.intel.com>
 <20190329011727.GC16680@redhat.com>
 <f053e75e-25b5-d95a-bb3c-73411ba49e3e@nvidia.com>
 <20190329014259.GD16680@redhat.com> <20190329015919.GF16680@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <f7710f64-c17e-feef-f453-e01340461e7e@nvidia.com>
Date:   Thu, 28 Mar 2019 19:05:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.3
MIME-Version: 1.0
In-Reply-To: <20190329015919.GF16680@redhat.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1553825125; bh=+1O9YpiNfEVCCc+AeXkWqW7U0Khy1QDft89NTnXa5GY=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=FRvCg0fME4TeQCUKe5tlbRFfjI9Gn+fL4I/dhgs3fcXV6xp3Bc1c8DDtPW/Opm+nb
         ae6YdMCZGFdkBREzXTd6995PTV+YFxEMWfQ5JbJkcFTibqmpasyWda4MuxekUso0Dw
         GV4Gw0twubnHa5WN4YG413vAcrTP7YSnkTqJRS6q2UrKUq7IEhq21G0OLwgeW/73uI
         ZnDXrV1pgRtf8m83kzsqcTuBgSsvwGgCM507T4p7cW53J71HhOQOoRpXMDZ3fkBYbE
         yDSEpTSfDqkJodqYtcnYAC0vFdVebPl88NFleKIe26mGoF9ZRhYq3W0u8SUeiNQbyb
         +8E48ZXB/twoA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/28/19 6:59 PM, Jerome Glisse wrote:
>>>>>> [...]
>>>>> Indeed I did not realize there is an hmm "pfn" until I saw this function:
>>>>>
>>>>> /*
>>>>>  * hmm_pfn_from_pfn() - create a valid HMM pfn value from pfn
>>>>>  * @range: range use to encode HMM pfn value
>>>>>  * @pfn: pfn value for which to create the HMM pfn
>>>>>  * Returns: valid HMM pfn for the pfn
>>>>>  */
>>>>> static inline uint64_t hmm_pfn_from_pfn(const struct hmm_range *range,
>>>>>                                         unsigned long pfn)
>>>>>
>>>>> So should this patch contain some sort of helper like this... maybe?
>>>>>
>>>>> I'm assuming the "hmm_pfn" being returned above is the device pfn being
>>>>> discussed here?
>>>>>
>>>>> I'm also thinking calling it pfn is confusing.  I'm not advocating a new type
>>>>> but calling the "device pfn's" "hmm_pfn" or "device_pfn" seems like it would
>>>>> have shortened the discussion here.
>>>>>
>>>>
>>>> That helper is also use today by nouveau so changing that name is not that
>>>> easy it does require the multi-release dance. So i am not sure how much
>>>> value there is in a name change.
>>>>
>>>
>>> Once the dust settles, I would expect that a name change for this could go
>>> via Andrew's tree, right? It seems incredible to claim that we've built something
>>> that effectively does not allow any minor changes!
>>>
>>> I do think it's worth some *minor* trouble to improve the name, assuming that we
>>> can do it in a simple patch, rather than some huge maintainer-level effort.
>>
>> Change to nouveau have to go through nouveau tree so changing name means:

Yes, I understand the guideline, but is that always how it must be done? Ben (+cc)?

>>  -  release N add function with new name, maybe make the old function just
>>     a wrapper to the new function
>>  -  release N+1 update user to use the new name
>>  -  release N+2 remove the old name
>>
>> So it is do-able but it is painful so i rather do that one latter that now
>> as i am sure people will then complain again about some little thing and it
>> will post pone this whole patchset on that new bit. To avoid post-poning
>> RDMA and bunch of other patchset that build on top of that i rather get
>> this patchset in and then do more changes in the next cycle.
>>
>> This is just a capacity thing.
> 
> Also for clarity changes to API i am doing in this patchset is to make
> the ODP convertion easier and thus they bring a real hard value. Renaming
> those function is esthetic, i am not saying it is useless, i am saying it
> does not have the same value as those other changes and i would rather not
> miss another merge window just for esthetic changes.
> 

Agreed, that this minor point should not hold up this patch.

thanks,
-- 
John Hubbard
NVIDIA