Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1075159ybb;
        Thu, 28 Mar 2019 19:12:08 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwMVoTZ9+NUI0L6Nu7LgHgxPdo3C5fWWsecf+rnLLxtgUskJlc9PQHOHPD+isxoOlLIHLOr
X-Received: by 2002:aa7:8d01:: with SMTP id j1mr45524207pfe.122.1553825528643;
        Thu, 28 Mar 2019 19:12:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1553825528; cv=none;
        d=google.com; s=arc-20160816;
        b=ISSyAzHIoM9Q7f1WPJhcBuPPvzTioM20D2OzbjciCca0LVku3Cpq88QtcKmO30O6j4
         mtJ4xFVTFwgHrC7u95L3br7MSc2cIaXT7sOXQlsGi8u43ofz+1Tv3X8L5sp8HxIJQRHC
         Lb/jRHpLnSNSM1E5eVsWBXZ0oL4Es/U0CNDAzugiDs5XEib+5ma353BquMH7HSQvp4cT
         icTTayoSkhym6mhO6NOO7lmQosvRASR5ELR4U4Jz4ilaZtkyvIso13kcp2K8spYchwIv
         LgVCnaN/RDXzexlQ0gFyUJQjjh0nP8yeqlMIhYp25cTFj9ykGyDryEA+eRPkQzeinyZc
         +DMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=kNXxnRe3M1ijRkP4yynTmx6uLTiKcabSICyOQfMgSMw=;
        b=yq9Fos2wFtAkI3A+JbhiMxSPFP4nKUYDZNCCP5KtJMKYQ8gUmslgaXuZM6BNeb5yde
         4BOfbKSLJCZ+sRrDFMhjbbJ5Y7BSiN3oUpA8KYW7ANYNadXarYJyDSI8iya/geYE0LjI
         RpOm4kEGBhWnQRw75R80ToX7+Nr5iyn/qyJOWAbl73OZlXPCuDmvURfQZPWqXXFCZILY
         bZ8fozrikonvb1LsvIh0e/vGnPb1OAt+oU1f3OVG5VF/sK5bN+8JfCbktSFh9aRFxLcn
         1cbw7ELbaNoTZI9Rp+D24kAAvHLspsWa8mXO5e0P5f2zmDgcqACodeyVTAlmkoIj4jBB
         vOAQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=TCCYngfr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id d11si692519pgh.447.2019.03.28.19.11.52;
        Thu, 28 Mar 2019 19:12:08 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=TCCYngfr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728359AbfC2CLT (ORCPT <rfc822;carmate383@gmail.com>
        + 99 others); Thu, 28 Mar 2019 22:11:19 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:5984 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727434AbfC2CLS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Mar 2019 22:11:18 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c9d7ec40001>; Thu, 28 Mar 2019 19:11:16 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 28 Mar 2019 19:11:17 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 28 Mar 2019 19:11:17 -0700
Received: from [10.110.48.28] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 29 Mar
 2019 02:11:17 +0000
Subject: Re: [PATCH v2 02/11] mm/hmm: use reference counting for HMM struct v2
To:     Jerome Glisse <jglisse@redhat.com>
CC:     Ira Weiny <ira.weiny@intel.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>
References: <20190325144011.10560-1-jglisse@redhat.com>
 <20190325144011.10560-3-jglisse@redhat.com>
 <20190328110719.GA31324@iweiny-DESK2.sc.intel.com>
 <20190328191122.GA5740@redhat.com>
 <c8fd897f-b9d3-a77b-9898-78e20221ba44@nvidia.com>
 <20190328212145.GA13560@redhat.com>
 <fcb7be01-38c1-ed1f-70a0-d03dc9260473@nvidia.com>
 <20190328165708.GH31324@iweiny-DESK2.sc.intel.com>
 <20190329010059.GB16680@redhat.com>
 <55dd8607-c91b-12ab-e6d7-adfe6d9cb5e2@nvidia.com>
 <20190329015003.GE16680@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <cc587c80-34ea-8d08-533d-0dc0c2fb079f@nvidia.com>
Date:   Thu, 28 Mar 2019 19:11:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.3
MIME-Version: 1.0
In-Reply-To: <20190329015003.GE16680@redhat.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1553825476; bh=kNXxnRe3M1ijRkP4yynTmx6uLTiKcabSICyOQfMgSMw=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=TCCYngfrlCQTvKv1rhpyIVK3LxaWz+hW7XDu8Fzz9E/d18QO1CqEZSqLswtry/e+k
         UrOnp6rld7LJCk+y6FB6xYN1orUNpKBjpF7gxkWh15FE/QSc2Ls6HIK6gOG6T8QHhH
         zVDoPrYKUbDfwd3pbHLSCYLtDOdb/ZMVJNIiiEzgooV072BV415VSMJ+gPjf/MAyxX
         FjKg1oym70nUDnOGY/vhLbTP1dhy6HTBWdb5F738n1Hud5sL50J7LDGCz2NfcCGsPR
         vwOrkHl/E8o01yxW4w9XdyfDc8dtAZM08lyhbdMr9jwsV97Ot8Dp0Fp0ZlEuZFD7w9
         vkAvK9PA2IttA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/28/19 6:50 PM, Jerome Glisse wrote:
[...]
>>>
>>> The hmm_put() is just releasing the reference on the hmm struct.
>>>
>>> Here i feel i am getting contradicting requirement from different people.
>>> I don't think there is a way to please everyone here.
>>>
>>
>> That's not a true conflict: you're comparing your actual implementation
>> to Ira's request, rather than comparing my request to Ira's request.
>>
>> I think there's a way forward. Ira and I are actually both asking for the
>> same thing:
>>
>> a) clear, concise get/put routines
>>
>> b) avoiding odd side effects in functions that have one name, but do
>> additional surprising things.
> 
> Please show me code because i do not see any other way to do it then
> how i did.
> 

Sure, I'll take a run at it. I've driven you crazy enough with the naming 
today, it's time to back it up with actual code. :)

I hope this is not one of those "we must also change Nouveau in N+M steps" 
situations, though. I'm starting to despair about reviewing code that
basically can't be changed...

thanks,
-- 
John Hubbard
NVIDIA