Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Manish Rangankar <mrangankar@marvell.com>
To:     Ding Xiang <dingxiang@cmss.chinamobile.com>,
        "QLogic-Storage-Upstream@qlogic.com" 
        <QLogic-Storage-Upstream@qlogic.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: bnx2fc: remove unneeded variable
Thread-Topic: [PATCH] scsi: bnx2fc: remove unneeded variable
Thread-Index: AQHU5d8EVwTq6D948k+hP2xl0Kz9z6Yh/1Hg
Date:   Fri, 29 Mar 2019 04:13:00 +0000
Message-ID: <BYAPR18MB2485B5A8C2997C9075E3454CD85A0@BYAPR18MB2485.namprd18.prod.outlook.com>
References: <1553829852-16525-1-git-send-email-dingxiang@cmss.chinamobile.com>
In-Reply-To: <1553829852-16525-1-git-send-email-dingxiang@cmss.chinamobile.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: abef1a81-a0ee-4e03-8f31-08d6b3fcd4c7
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2019 04:13:00.0981
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2871
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-29_02:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Ding Xiang <dingxiang@cmss.chinamobile.com>
> Sent: Friday, March 29, 2019 8:54 AM
> To: QLogic-Storage-Upstream@qlogic.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] scsi: bnx2fc: remove unneeded variable
>=20
> "rc" is unneeded,just return SUCCESS
>=20
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
>  drivers/scsi/bnx2fc/bnx2fc_io.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c
> b/drivers/scsi/bnx2fc/bnx2fc_io.c index bc9f2a2..8def63c 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1083,7 +1083,6 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd
> *sc_cmd)  static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)  {
>  	struct bnx2fc_rport *tgt =3D io_req->tgt;
> -	int rc =3D SUCCESS;
>  	unsigned int time_left;
>=20
>  	io_req->wait_for_comp =3D 1;
> @@ -1110,7 +1109,7 @@ static int bnx2fc_abts_cleanup(struct
> bnx2fc_cmd *io_req)
>  	kref_put(&io_req->refcount, bnx2fc_cmd_release);
>=20
>  	spin_lock_bh(&tgt->tgt_lock);
> -	return rc;
> +	return SUCCESS;
>  }
>=20
>  /**
> --
> 1.9.1
>=20

Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>