Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Junichi Nomura <j-nomura@ce.jp.nec.com>
To:     "bhe@redhat.com" <bhe@redhat.com>
CC:     Borislav Petkov <bp@alien8.de>, Dave Young <dyoung@redhat.com>,
        "fanc.fnst@cn.fujitsu.com" <fanc.fnst@cn.fujitsu.com>,
        "kasong@redhat.com" <kasong@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/boot: Use EFI setup data if provided
Thread-Topic: [PATCH v2] x86/boot: Use EFI setup data if provided
Thread-Index: AQHU5R0gSF49+PGwf02T2oxnk4CVXaYgAhGAgAAQvICAAQMcAIAASZeAgAAFLACAABdqAA==
Date:   Fri, 29 Mar 2019 05:16:42 +0000
Message-ID: <470e9a92-8433-f2a3-be0a-8306dcf50a73@ce.jp.nec.com>
References: <20190325122302.GC13160@dhcp-128-65.nay.redhat.com>
 <20190325123229.GL12016@zn.tnic>
 <20190325231000.GA9184@jeru.linux.bs1.fc.nec.co.jp>
 <20190326135714.GG1867@zn.tnic> <20190327014852.GA3659@MiWiFi-R3L-srv>
 <73322ba9-e436-68db-7863-afd31607d969@ce.jp.nec.com>
 <20190328064343.GA1877@MiWiFi-R3L-srv>
 <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp>
 <20190328231100.GC1877@MiWiFi-R3L-srv>
 <ed9b7ab0-c9c4-a0b8-f4b7-709e597c6f0b@ce.jp.nec.com>
 <20190329035254.GD1877@MiWiFi-R3L-srv>
In-Reply-To: <20190329035254.GD1877@MiWiFi-R3L-srv>
Accept-Language: en-US, ja-JP
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <6DD88A3FFA7E5049ACA55F86D24F606B@gisp.nec.co.jp>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/29/19 12:52 PM, bhe@redhat.com wrote:
> 2)
>  __efi_get_rsdp_addr() {
>          for (i = 0; i < nr_tables; i++) {
>                  if (efi_64) {
> 			efi_config_table_64_t *tbl = (efi_config_table_64_t *)config_tables + i;
>                          // get guid and table
>                  } else {
> 			efi_config_table_32_t *tbl = (efi_config_table_32_t *)config_tables + i;
>                          // get guid and table
>                  }
>                  // check guid and return table if it's valid
>          }
>  }

Thanks. This looks nice and doesn't conflict the direction of refactoring, I think.

-- 
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.