Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1261466ybb; Fri, 29 Mar 2019 00:33:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+E7cg9fcOxJEiCorO9PhjwXsBg0DNAO/4LgSQiKGKeBtLTls6+vFOByIQJNWo8D2bTHfi X-Received: by 2002:a63:1749:: with SMTP id 9mr42788167pgx.94.1553844783150; Fri, 29 Mar 2019 00:33:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553844783; cv=none; d=google.com; s=arc-20160816; b=ByZk7YJCCOeyCVpeAJzOmOv4AwfrSoZhR5iKFk4/B3tORb8mJDIR8tMGwSBtnRkDmN rBwsvN1sVQCtcC1ggKwgzv+Jp4d8gahf1UaJZnIVSs9VHbX8WP1lQkbzbQiX8IaBKECV UjE20UJwC0FCiFzRaFaZi6dVnO1lG+qye2BEfTPuSGNKF7dBbgOBWwEVjEy2UZBTFJoE aH1ztKC/yZ+hNISnfIKFYZZK0Z91UpPU5r4G1L32+RpbU8rIIKBIGl26ZiBLU+652kZ6 w4NJB/+8b3xlIJDxiCIB1ATYN1r+KkTLwjg/8gS0VphYOxvamnCKctruw8YX6hOwOXgo KMeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=A+tZ7XYQykbIjw5JmlgD8POyw4cnR+gEsgER2RW0Jms=; b=jBYwUrC3nyQVFUO6hzrA3o4PlVIgXkkdgDgxVxWzV0VoHz496LMSx59Ot+qKIZVfWi X8Uc9EMj3dfnpnTVBeMl1G0Q6T94Tanm+crbedP6b8TpCkTNdnf0i6DKeTSDZqsXl8ES H8V7ONWHvX4JlVXm0TXrCvZmDr/lxn5qLEHxbI0qVsWAORFl7lMt9DciPPbOyM+GEdo5 /Eo52INcs0nlsBABbW6yyU9ftSlX0V+RdzNqpG6gHygGVnr3Jalh0ZHHQRQkBoW0P3wn 8QvV0pirfSF2W5TtVBzughHAeUkqzz/yd3rnWattpZFMoEjg2V0woxxpOD+0hu5750xD JkNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=LQmIpF40; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj1si1239995plb.15.2019.03.29.00.32.47; Fri, 29 Mar 2019 00:33:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=LQmIpF40; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728995AbfC2HaR (ORCPT + 99 others); Fri, 29 Mar 2019 03:30:17 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:64945 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728865AbfC2H3j (ORCPT ); Fri, 29 Mar 2019 03:29:39 -0400 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-10.nifty.com with ESMTP id x2T7SQaA002537; Fri, 29 Mar 2019 16:28:29 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x2T7SQaA002537 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1553844509; bh=A+tZ7XYQykbIjw5JmlgD8POyw4cnR+gEsgER2RW0Jms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LQmIpF40uifpUy/TRK/8ysQgKQf6z59bbQFLTOrV7UgH7HYydBuxRUcEBn1B/DeVE MVBdOuGrWMk92VCyE4xIi7BreFiL1QDz00JSdHeDnsAUEdMuHvXPG9hdCBKeXVgFbB ae2XF2GBSVNiDAiVFLzUKn+krK2MUc47iFHedF3JuQBVBMwEZV/ybuhiTjPMR/2Yco DALfaTtk9rSiO2cZ1Qfp44wcgY0+jUOL+o/5QnjZKEta4k1p5RHwnXRi5kqlHc/uOt gPTyWo1Jfl07cDH6HKvAYv6ISqDY/N20v/hTKu+GhyDfmFtXFwQ3tfMxji1Xo2WVxu R5CfPoPoVLq3g== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Cc: Masahiro Yamada , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse , Boris Brezillon Subject: [PATCH v4 3/9] mtd: rawnand: denali: remove unneeded casts in denali_{read,write}_pio Date: Fri, 29 Mar 2019 16:28:15 +0900 Message-Id: <1553844501-7119-4-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1553844501-7119-1-git-send-email-yamada.masahiro@socionext.com> References: <1553844501-7119-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since (u32 *) can accept an opaque pointer, the explicit casting from (void *) to (u32 *) is redundant. Change the function argument type to remove the casts. Signed-off-by: Masahiro Yamada --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index 9b27338..bf968cc 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -654,11 +654,10 @@ static void denali_setup_dma32(struct denali_nand_info *denali, denali->host_write(denali, mode | 0x14000, 0x2400); } -static int denali_pio_read(struct denali_nand_info *denali, void *buf, +static int denali_pio_read(struct denali_nand_info *denali, u32 *buf, size_t size, int page) { u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page; - uint32_t *buf32 = (uint32_t *)buf; uint32_t irq_status, ecc_err_mask; int i; @@ -670,7 +669,7 @@ static int denali_pio_read(struct denali_nand_info *denali, void *buf, denali_reset_irq(denali); for (i = 0; i < size / 4; i++) - *buf32++ = denali->host_read(denali, addr); + buf[i] = denali->host_read(denali, addr); irq_status = denali_wait_for_irq(denali, INTR__PAGE_XFER_INC); if (!(irq_status & INTR__PAGE_XFER_INC)) @@ -682,18 +681,17 @@ static int denali_pio_read(struct denali_nand_info *denali, void *buf, return irq_status & ecc_err_mask ? -EBADMSG : 0; } -static int denali_pio_write(struct denali_nand_info *denali, - const void *buf, size_t size, int page) +static int denali_pio_write(struct denali_nand_info *denali, const u32 *buf, + size_t size, int page) { u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page; - const uint32_t *buf32 = (uint32_t *)buf; uint32_t irq_status; int i; denali_reset_irq(denali); for (i = 0; i < size / 4; i++) - denali->host_write(denali, addr, *buf32++); + denali->host_write(denali, addr, buf[i]); irq_status = denali_wait_for_irq(denali, INTR__PROGRAM_COMP | INTR__PROGRAM_FAIL); -- 2.7.4