Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8C3D8602F8
Subject: Re: [PATCH] lib/scatterlist: Remove leftover from sg_page_iter
 comment
To:     Gal Pressman <galpress@amazon.com>, linux-kernel@vger.kernel.org
Cc:     Jason Gunthorpe <jgg@mellanox.com>
References: <1553800491-28583-1-git-send-email-galpress@amazon.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <8e313491-8859-d47f-f104-6d2d783cd63a@codeaurora.org>
Date:   Fri, 29 Mar 2019 14:06:04 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1553800491-28583-1-git-send-email-galpress@amazon.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/29/2019 12:44 AM, Gal Pressman wrote:
> Commit d901b2760dc6 ("lib/scatterlist: Provide a DMA page iterator")
> added the sg DMA iterator but a leftover remained in the sg_page_iter
> documentation, remove it.
>
> Cc: Jason Gunthorpe <jgg@mellanox.com>
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
>   include/linux/scatterlist.h | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
> index b4be960c7e5d..30a9a55c28ba 100644
> --- a/include/linux/scatterlist.h
> +++ b/include/linux/scatterlist.h
> @@ -340,11 +340,11 @@ int sg_alloc_table_chained(struct sg_table *table, int nents,
>    * sg page iterator
>    *
>    * Iterates over sg entries page-by-page.  On each successful iteration, you
> - * can call sg_page_iter_page(@piter) to get the current page and its dma
> - * address.


It took me a while till i exact found what you meant by left over.

could have been more specific in the commit,but

Looks  good to me to be removed.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh


>   @piter->sg will point to the sg holding this page and
> - * @piter->sg_pgoffset to the page's page offset within the sg. The iteration
> - * will stop either when a maximum number of sg entries was reached or a
> - * terminating sg (sg_last(sg) == true) was reached.
> + * can call sg_page_iter_page(@piter) to get the current page.
> + * @piter->sg will point to the sg holding this page and @piter->sg_pgoffset to
> + * the page's page offset within the sg. The iteration will stop either when a
> + * maximum number of sg entries was reached or a terminating sg
> + * (sg_last(sg) == true) was reached.
>    */
>   struct sg_page_iter {
>   	struct scatterlist	*sg;		/* sg holding the page */