Message-ID: <4067375E.4040206@pobox.com>
Date: Sun, 28 Mar 2004 15:36:46 -0500
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
MIME-Version: 1.0
To: dsaxena@plexity.net
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6-BK] Allow arch-specific pci_dma_set_mask
References: <20040327000639.GA29290@plexity.net>
In-Reply-To: <20040327000639.GA29290@plexity.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1160
Lines: 40

Deepak Saxena wrote:
> Jeff, 
> 
> Following is a patch that allows for architectures to override 
> pci_set_dma_mask and friends for systems that need to do so such
> as the ARM IXP425. Instead of having invidual HAVE_ARCH_FOO
> for each of the three mask functions, I think it just makes more
> sense to have one for overrdding all three since chances are
> if you need to override one, you need to do so for all of them.
> 
> Tnx,
> ~Deepak
> 
> ===== drivers/pci/pci.c 1.63 vs edited =====
> --- 1.63/drivers/pci/pci.c	Sun Mar 14 12:17:06 2004
> +++ edited/drivers/pci/pci.c	Fri Mar 26 16:58:01 2004
> @@ -658,6 +658,10 @@
>  	}
>  }
>  
> +#ifndef HAVE_ARCH_PCI_SET_DMA_MASK
> +/*
> + * These can be overridden by arch-specific implementations
> + */
>  int
>  pci_set_dma_mask(struct pci_dev *dev, u64 mask)


Looks OK to me, but it's really up to arch people.  I just follow the 
API I'm given.  :)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/