Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v7 0/4] drm: add support for Cadence MHDP DPI/DP bridge.
To:     Damian Kos <dkos@cadence.com>
CC:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Sean Paul <sean@poorly.run>, Sandy Huang <hjc@rock-chips.com>,
        Anil Joy Varughese <aniljoy@cadence.com>,
        =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-rockchip@lists.infradead.org" 
        <linux-rockchip@lists.infradead.org>,
        "jbergsagel@ti.com" <jbergsagel@ti.com>,
        "quentin.schulz@bootlin.com" <quentin.schulz@bootlin.com>,
        Piotr Sroka <piotrs@cadence.com>,
        Rafal Ciepiela <rafalc@cadence.com>,
        "Sarha, Jyri" <jsarha@ti.com>
References: <1548846209-16406-1-git-send-email-dkos@cadence.com>
 <0f11a4d8-d576-5af8-b7f4-afe3ff26678f@ti.com>
 <ce6ed2e6-90d5-fc7a-4d6d-ab27d62c5432@ti.com>
 <BYAPR07MB43111E34594899FC375D16BDCD580@BYAPR07MB4311.namprd07.prod.outlook.com>
From:   Tomi Valkeinen <tomi.valkeinen@ti.com>
Message-ID: <5f7a3cdf-b5b5-34ef-ca58-b75b9bc1c326@ti.com>
Date:   Fri, 29 Mar 2019 11:42:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <BYAPR07MB43111E34594899FC375D16BDCD580@BYAPR07MB4311.namprd07.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 27/03/2019 16:58, Damian Kos wrote:

> We would be very happy to have a separate driver for mhdp8546 instead of
> mixing it with Rockchip's driver. Unfortunately we need to have one driver
> for both IP's, so I'll just change mhdp8546.ko to cdns-mhdp.ko. (Unless,
> maintainers give us a green light for the dedicated driver?)

Ok. I don't know about the differences, so I can't say much here. But I
do think that you shouldn't combine drivers for two different IPs unless
they are very similar. And if two different IPs have a block that's the
same/similar, the code for that block can be extracted to a "library"
used by both drivers.

>>> I see some audio functions in the code, but it's not mentioned in the DT
>>> bindings. I'm not an audio guy, but the display bridges with audio
>>> support I have seen have had DT bindings for the audio source too. Is
>>> audio supported in the current driver?
>>>
> As far as I know, audio is working, but I can't double check it right now
> due to heavy load on my back right now. I'll try to find time for that in the
> next week. But, like I've mentioned earlier I don't see a reason why audio
> code (that exists in the mainline) wouldn't work.
> I'm not an audio guy myself. When updating dt bindings I took the dt bindings
> for other bridges as an example, but I did not see any bindings for audio in
> them. I didn't check all of them. Can you please let me know which bridges
> are you were referring to? In our test environment we didn't use any audio
> driver as audio generator is so simple that it is part of the register space
> of IP and we didn't even need to include this device in .dts file. Audio (like
> the video) is configured and enabled by code that is not included in the patch
> (for obvious reasons).
> So, in short, yes, driver supports audio and we will include description for
> audio input port in the dt bindings.

Ok. Jyri Sarha <jsarha@ti.com> recently sent "drm/bridge: sii902x:
HDMI-audio support and some fixes" series, and I think tda998x_drv.c
also has some audio support. But I'm no audio guy either =). I was just
curious about the status of the audio.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki