Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A45FB6063A
Subject: Re: [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks
To:     Neeraj Upadhyay <neeraju@codeaurora.org>,
        paulmck@linux.vnet.ibm.com, josh@joshtriplett.org,
        rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
        jiangshanlai@gmail.com, joel@joelfernandes.org
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1553853352-14253-1-git-send-email-neeraju@codeaurora.org>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <35a95581-138d-b047-b809-aff803287a23@codeaurora.org>
Date:   Fri, 29 Mar 2019 15:42:44 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1553853352-14253-1-git-send-email-neeraju@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/29/2019 3:25 PM, Neeraj Upadhyay wrote:
> dump_blkd_tasks() uses 10 as the max number of blocked
> tasks, which are printed. However, it has an argument
> which provides that number. So, use the argument value
> instead. As all callers currently pass 10 as the number,
> there isn't any impact.
>
> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>

Looks good to me.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
>   kernel/rcu/tree_plugin.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 3960294..08bcd87 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -740,7 +740,7 @@ void exit_rcu(void)
>   	i = 0;
>   	list_for_each(lhp, &rnp->blkd_tasks) {
>   		pr_cont(" %p", lhp);
> -		if (++i >= 10)
> +		if (++i >= ncheck)
>   			break;
>   	}
>   	pr_cont("\n");