Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1404029ybb; Fri, 29 Mar 2019 03:59:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqxL0bn93f473m0ODMPBxIiGHS3H1QwUTg1NBimIXHl9U9pUMhFXrC/p0Ibj7zsh6OYyCXab X-Received: by 2002:a63:e755:: with SMTP id j21mr42190464pgk.418.1553857182734; Fri, 29 Mar 2019 03:59:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553857182; cv=none; d=google.com; s=arc-20160816; b=qX0MzqwKbcdRzO+1kkkyKDeTS2Bbl1l1syLkIu8lr1rxrbESSNO6xIYkBv5hXsoJ7y 4YiORnby7hOFmw2ZWJ1eZ4ycmzII5kF3ayFjMplh8dcRocadGqWaRigTiO+YbsK3SkNF Bjoj8GV7MYv0IfV7Cbj7S/g0xV1dbHaLUvs+scnw4QRkyaS03GwrYCiC1ppv218F4TaI rXJPUdc+GwasrbI3l7UeyJbc3H6x2YU905/QJIgoJDj12rNOeyQgOgtLEVRfGTvGP1AM axbqWN8bXTILFNHYXCLvABekSMKQRmpKn32/LNKBPQlNbi1JVQDd5VYr1mZO0c1bHDIh LX2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date; bh=Lo/F3RgO6+8BdrxpqPI/cpMKVjqlY1rFevsPT66dIGc=; b=c7S6MNbTPvh0Q9cIM0JA4SSVj0kugJwKwrn2vl2HVSfwy1J3TIdOTfRujy+RNUO2fH 9QPU58AbqdeFMtzTcHe6qGiFfG7t7K+yjbxtJmhzqlUbdhBYbE5NwiY0y4wUpjqw5F3D ad7X6lGYCNvvfPa0rRgTbvsFRAXjjm85iAUjUh6s+ZRxS7LWQRAat+2wjdqpYway+gIk ZkmlrUocopQlCfQkGGa/1tvIhZWo3D4NfXLDLQTY0Xj2XnsQxQAuWmoVkbNDYrmfi9V0 TXop1XaiJJdB+XsqvCQBmDYYu3z1cnKLtK0/DOIu+zDZ3PKBeinLy9f02Wwu5h/sDCTc xXNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f18si1683873pgg.361.2019.03.29.03.59.27; Fri, 29 Mar 2019 03:59:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729372AbfC2K6T (ORCPT + 99 others); Fri, 29 Mar 2019 06:58:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56378 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727788AbfC2K6S (ORCPT ); Fri, 29 Mar 2019 06:58:18 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49932308620F; Fri, 29 Mar 2019 10:58:18 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id E142860852; Fri, 29 Mar 2019 10:58:17 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 04944A1E0; Fri, 29 Mar 2019 11:58:16 +0100 (CET) Date: Fri, 29 Mar 2019 11:58:16 +0100 From: Gerd Hoffmann To: Rodrigo Siqueira , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] drm/atomic-helper: Make atomic_enable/disable crtc callbacks optional Message-ID: <20190329105816.5mru5gcvjoxrtuhp@sirius.home.kraxel.org> References: <20190314184845.gjmvkamobj4dilyp@smtp.gmail.com> <20190315110031.GY2665@phenom.ffwll.local> <20190325112906.p4zfgom3by3f2zu4@smtp.gmail.com> <20190326075003.GH2665@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326075003.GH2665@phenom.ffwll.local> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 29 Mar 2019 10:58:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 26, 2019 at 08:50:03AM +0100, Daniel Vetter wrote: > On Mon, Mar 25, 2019 at 08:29:06AM -0300, Rodrigo Siqueira wrote: > > On 03/15, Daniel Vetter wrote: > > > On Thu, Mar 14, 2019 at 03:48:45PM -0300, Rodrigo Siqueira wrote: > > > > Allow atomic_enable and atomic_disable operations from > > > > drm_crtc_helper_funcs struct optional. With this, the target display > > > > drivers don't need to define a dummy function if they don't need one. > > > > > > > > Changes since v2: > > > > * Don't make funcs optional > > > > * Update kerneldoc for atomic_enable/disable > > > > * Replace "if (funcs->atomic_enable)" by "if (funcs->commit)" > > > > * Improve commit message > > > > > > > > Signed-off-by: Rodrigo Siqueira > > > > > > Reviewed-by: Daniel Vetter > > > > Hi, > > Is it ok if I apply this patch? > > Sure. > -Daniel Hmm, seems to not be applied yet. Pushed to drm-misc-fixes. cheers, Gerd