Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1408423ybb; Fri, 29 Mar 2019 04:04:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFQjUC4fegNy9jJnrA41Qm5+8yDwrjMjRni7ZhPWIsSRPWCHiU61p7hdtSeqQLtL62o67v X-Received: by 2002:a63:e10b:: with SMTP id z11mr41464448pgh.46.1553857464722; Fri, 29 Mar 2019 04:04:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553857464; cv=none; d=google.com; s=arc-20160816; b=rlR0k20HZP36CJmBCfjiZ3R0AwzXvvU7ElmPhhOuAyAxBSvFJ1rCqQXeKRdbwS6zbU pT3G90fv/tqmTfOa/imST7Qic24SbK7qdeo2gF/28FJ6L26/TZBnzFrV9YwHC/wAoMQ0 /gB/vMY+9MB5YfQe/PzhRAqoTpaLA8oViYbAI2+nwBUKsO3Sp2/h5bTHnbafm4pU7prX 3PHnZ/sntRldu3SO++/kgm3OSQOdvVAFRorJ7RPtuJb9sufIeL6da6wM9oUKndCwwBd9 B0lKkpx50ewmrpkfhCr2RzDA7eTPc7iObQbrcLEcKVoOd5M0CRflqlr92ehTPlQwj9Lx rlyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZHfTymQFHSl6HXWw9TRWSFfgK57Gz5hPFe96mnLTIT8=; b=rLhAeS+KTybittalyTWk5KCk81xDFv9FRd4nHSq77/Jrzh3GJJX0923/3Nz32yCKKL ncKS3UO343EA0CaETvaHBYLqSQSNotAhjc/LdeNjrfiEOOQTf6sBnYJ8Tu1xTSajBthj Yo54YR7OGqs9q2fW8ftKkt4ag9VxN40durCewcVGStwq5V4BI06r1y+N+6/XZ2g1GPoi Y1OC2RBgfFBFSamTE/7RmDV/LImMKWJSMlpMiwH8FScQOiU6PHU8kFnsXwFPdizwAA5D cde/CBKEAtFPLgjGU3xg46jxzhWIpcYCaawC9jHMx+3xRHnVdLsFImQdRcrt4qCfM/zi RRwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=qqD4PJ2M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c12si1683519pgk.202.2019.03.29.04.04.09; Fri, 29 Mar 2019 04:04:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=qqD4PJ2M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729145AbfC2LD2 (ORCPT + 99 others); Fri, 29 Mar 2019 07:03:28 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:51732 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728545AbfC2LD2 (ORCPT ); Fri, 29 Mar 2019 07:03:28 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2TAwpHo032792; Fri, 29 Mar 2019 11:03:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=ZHfTymQFHSl6HXWw9TRWSFfgK57Gz5hPFe96mnLTIT8=; b=qqD4PJ2MO/wj4nZ/g1CCvhsk72Y4hQNnTUcBt0M7bKrN5LEVz20nbGOusOtI4zIztbhp LEpjnu8LpSectuhAxT0JX8W0aTWUdbo4ZQBkB5XO3C9zf1B6sc9HRm+vWR4M5pQzQN4P ntdcs8/3kY8iNHZL/yBzhpN+QeYCgutKYAEseb7eswuoxmggJqVAqNjRoQRSt85pa/4g gPwn5gvm9oIto5z8VbYaa8yp4G034SYOlVwjwnD57c6Ieg4h2tsZb8kewnohwEpCuL19 Cb1RfhbqAKqYjQeITHGwct8eRolPattdQGGNmcaxJDh6T5KQ6n+zyorn98Q/44woiVo0 0Q== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2re6g1kqr5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Mar 2019 11:03:12 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2TB3BZN031960 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Mar 2019 11:03:12 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2TB39Ur007914; Fri, 29 Mar 2019 11:03:09 GMT Received: from kadam (/41.202.241.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 29 Mar 2019 04:03:08 -0700 Date: Fri, 29 Mar 2019 14:02:58 +0300 From: Dan Carpenter To: Zeng Tao Cc: labbott@redhat.com, sumit.semwal@linaro.org, devel@driverdev.osuosl.org, Todd Kjos , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Joel Fernandes , Martijn Coenen , Christian Brauner Subject: Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use Message-ID: <20190329110258.GB32590@kadam> References: <1553884816-37850-1-git-send-email-prime.zeng@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1553884816-37850-1-git-send-email-prime.zeng@hisilicon.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9210 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=684 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903290080 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we're going to export ion_alloc() for other drivers to use then let's make an ion_free() helper function as well. void ion_free(struct dma_buf *dmabuf) { dma_buf_put(dmabuf); } regards, dan carpenter