Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C3F0A6053B
Subject: Re: [PATCH] clk:mmp: clk-mix.c fix divide-by-zero
To:     nixiaoming <nixiaoming@huawei.com>, mturquette@baylibre.com,
        sboyd@kernel.org, chao.xie@marvell.com
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1553859960-31501-1-git-send-email-nixiaoming@huawei.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <2882780e-ac45-c5e7-26fd-a1882a67113a@codeaurora.org>
Date:   Fri, 29 Mar 2019 18:11:34 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1553859960-31501-1-git-send-email-nixiaoming@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/29/2019 5:16 PM, nixiaoming wrote:
> The _get_div function has a branch with a return value of 0
> Add a check on the return value of _get_div to avoid divide-by-zero
>
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>

Fix the below minor comments..
Otherwise things look good..you can take mine
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

after fixing it.


Cheers,
-Mukesh


> ---
>   drivers/clk/mmp/clk-mix.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c
> index 90814b2..9d152c2 100644
> --- a/drivers/clk/mmp/clk-mix.c
> +++ b/drivers/clk/mmp/clk-mix.c
> @@ -245,6 +245,8 @@ static int mmp_clk_mix_determine_rate(struct clk_hw *hw,
>   			div_val_max = _get_maxdiv(mix);
>   			for (j = 0; j < div_val_max; j++) {
>   				div = _get_div(mix, j);
> +				if (!div) /* avoid divide-by-zero */

Please move this comment at the top of the check.


> +					continue;
>   				mix_rate = parent_rate / div;
>   				gap = abs(mix_rate - req->rate);
>   				if (!parent_best || gap < gap_best) {
> @@ -341,6 +343,8 @@ static unsigned long mmp_clk_mix_recalc_rate(struct clk_hw *hw,
>   	shift = mix->reg_info.shift_div;
>   
>   	div = _get_div(mix, MMP_CLK_BITS_GET_VAL(mux_div, width, shift));
> +	if (!div) /* avoid divide-by-zero */
ditto
> +		return -EINVAL;
>   
>   	return parent_rate / div;
>   }