Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B01A760735
Subject: Re: [PATCH v1] mm: balloon: drop unused function stubs
To:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Konstantin Khlebnikov <koct9i@gmail.com>,
        Pankaj Gupta <pagupta@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Michael S . Tsirkin" <mst@redhat.com>, linux-mm@kvack.org
References: <20190329122649.28404-1-david@redhat.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <931b7a25-94c9-5a13-423e-27ef41655603@codeaurora.org>
Date:   Fri, 29 Mar 2019 19:25:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190329122649.28404-1-david@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/29/2019 5:56 PM, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   include/linux/balloon_compaction.h | 15 ---------------
>   1 file changed, 15 deletions(-)


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
>   	list_del(&page->lru);
>   }
>   
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> -	return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> -	return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> -	return false;
> -}
> -
>   static inline bool balloon_page_isolate(struct page *page)
>   {
>   	return false;