From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Pavel Machek <pavel@ucw.cz>, Arthur Othieno <a.othieno@bluewin.ch>
Subject: Re: Kill IDE debug messages during suspend
Date: Mon, 29 Mar 2004 00:55:25 +0200
User-Agent: KMail/1.5.3
Cc: kernel list <linux-kernel@vger.kernel.org>,
       Rusty trivial patch monkey Russell 
	<trivial@rustcorp.com.au>
References: <20040326001154.GA3353@elf.ucw.cz> <20040328205822.GA846@mars> <20040328222502.GJ406@elf.ucw.cz>
In-Reply-To: <20040328222502.GJ406@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200403290055.25084.bzolnier@elka.pw.edu.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 32

On Monday 29 of March 2004 00:25, Pavel Machek wrote:
> Hi!
>
> > What about these stale #ifdefs?
> >
> > drivers/ide/ide-io.c:126:#ifdef DEBUG_PM
> > drivers/ide/ide-io.c:220:#ifdef DEBUG_PM
> > drivers/ide/ide-io.c:638:#ifdef DEBUG_PM
> > drivers/ide/ide-io.c:662:#ifdef DEBUG_PM
>
> I wanted to leave debugging possible...
>
> > This patch sweeps up both DEBUG_PM and DEBUG #ifdefs in favour of
> > pr_debug()

Well, I doubt anybody wants to debug taskfile IOs and PM at the same time.
[ pm_debug() ? ]

BTW adding -DDEBUG to EXTRA_CFLAGS in Makefile is cleaner
than defining/undefining it inside .c or .h.

> ...but your patch looks better.
> 								Pavel
>
> >  ide-io.c |   74
> > ++++++++++++++++++++++++++-------------------------------------

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/