Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1573696ybb; Fri, 29 Mar 2019 07:11:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqx60kFJDrnXubCgeWocKKreR1PlHf/ajwMk3P51gMHRR2nv/8jYJuijQ6Ri/OP1TGyFnZDU X-Received: by 2002:aa7:8a95:: with SMTP id a21mr47163695pfc.14.1553868693426; Fri, 29 Mar 2019 07:11:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553868693; cv=none; d=google.com; s=arc-20160816; b=zfXy+mRDiYzjAYxXP2qW90sXaan2tKX5uPsbBGlQdyxe8mgOfcLzkZHGBvcD3tErmH o5LlwJMylB0mMsqFI1igjxV9nC6sqMF+j9foy8l5B1nsqOP1Jd/BbrmFNYpf3zWgIb4B R7IX4gOqweYaob2vSiYtaKd4gTIzbx7QJUgpYocn1X05yWlUoCuSyYbm0E6Ib2nvg7VJ b5OngbLIRTxJQSfkM+MkB9xB/b/jfcppUdrRmXdmPox3K9kol/oIIeUzi8JBJJTeMp6D ZYIcDzaLcJ39CBk+459TpcOojbODdaqU4dsuN09t56LJQV0QZUzC7K1lecy639zLWRPX YnzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=InFNj43Ew+zCZHSNgM4rGAqFiRaGJhlAqF5jIgxZqrQ=; b=aN/VVbajykInkdvX0IHM32mdj1rXmaeMHtHDBdfDHHypCPHoVQ4Gz+EuOEe0XxgOLt 9FCViAEZy5E/M2MJVp5KiOk1bvwkXjN+5mPRLQclzGAdWWW45JOoyU3s7S76sb7lRFay 0b3szZpLNf5EAukmBJZ2XS4Gdm37yF81UzCfp66rjkxWfBxnnWY9V7OoaewiOw+t3Nvj 1xlDMTKHK1V+JrkcmbZ+754kpnO4JdZhEBqdSimh5nrXRXM+Zzr3zHqmyL0vubbaGafU Tpm+9g6q4P+7l1V2sb+LRcL45jzyi5nT6vT9WwxYJhKWa9sYYmpzzX89QksJzEbfKnca 3muw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Hzrd13p4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f73si1913370pff.184.2019.03.29.07.11.17; Fri, 29 Mar 2019 07:11:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Hzrd13p4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729156AbfC2OKl (ORCPT + 99 others); Fri, 29 Mar 2019 10:10:41 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:46475 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728808AbfC2OKl (ORCPT ); Fri, 29 Mar 2019 10:10:41 -0400 Received: by mail-io1-f68.google.com with SMTP id b9so1801273iot.13 for ; Fri, 29 Mar 2019 07:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=InFNj43Ew+zCZHSNgM4rGAqFiRaGJhlAqF5jIgxZqrQ=; b=Hzrd13p4BfDoZijAoBqMNkX/RL1AjjiYrqxr6RxGIuH2eYPg1YHh5EgmMNsXp2KSvt QX7zak8YntPOEH/F3XtCxTts+ZoarAGlTh/V8scjWKGr93u81ztKWMO+6zGL//dznWOe jxic1068pnpG52O4giIvypSvVpPashLRsYLvCE9whD2/VXzuOvT08wPwc1E304pV3SG2 K4ZIoFNX13aQWZXu8hzB275LWNSzBsp4DTmp8KjzvIMgCTkwfIH/kM1PSLf+5/hQHAbU G8wOUYuwyDRAmLtx1rrVh9IS+ldca4RIdZhpYDMIXvfPoonmfMtnvgePvoZ1bR8E2hhM /fWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=InFNj43Ew+zCZHSNgM4rGAqFiRaGJhlAqF5jIgxZqrQ=; b=gL2KhtY19M84h7mbw+E4I+k7H0AJGWrAC5YzAcNrQbxzInpFVSCOCSGQvAVRV70zLo SkBcjOoxPVd0blUvwVTTh+XUfyQHi2eEnLudNHW2tSOtd9leHYQVh11mXfGfapubjBk/ XUX4L0UaHiJJ62T+WM4KAq8qm1qYx2IrMRsY5hT6JVq2YjllMt65ejm1TT8ilDs/UMh5 BjZn9f4ygjUns4Nkz/N7l1EmlkqYqzJZQ8pU1uBleha3bQxxsU5zRI3kQ6FuzgGYIFWg +X97MmqM8qFbNPiTVqTlH+EBIfDuG8yIoCZVprV6SyHF2UCvQlCeAWZAJqpV+QzINZQU We5Q== X-Gm-Message-State: APjAAAVcCrBTmispgU0gXJ4rAQmsi5/M+8drGWudBPkodTkus/sGb6sM pglhizFi0wAv4ErIsfDh5mkZCQ== X-Received: by 2002:a5e:8a07:: with SMTP id d7mr35777563iok.194.1553868640406; Fri, 29 Mar 2019 07:10:40 -0700 (PDT) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id m6sm812672ioj.36.2019.03.29.07.10.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 07:10:39 -0700 (PDT) Subject: Re: Bisected GFP in bfq_bfqq_expire on v5.1-rc1 To: Dmitrii Tcvetkov , linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Paolo Valente References: <20190329160227.7d55c8dd@fire.localdomain> From: Jens Axboe Message-ID: <0e203a26-b941-cef4-dff1-013999d4b041@kernel.dk> Date: Fri, 29 Mar 2019 08:10:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190329160227.7d55c8dd@fire.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/19 7:02 AM, Dmitrii Tcvetkov wrote: > Hi, > > I got kernel panic since v5.1-rc1 when working with files on block > device with BFQ scheduler assigned. I didn't find trivial way to > reproduce the panic but "git checkout origin/linux-5.0.y" > on linux-stable-rc[1] git repo on btrfs filesystem reproduces the > problem 100% of the time on my bare-metal machine and in a VM. > > Bisect led me to commit 9dee8b3b057e1 (block, bfq: fix queue removal > from weights tree). After reverting this commit on top of current > mainline master(9936328b41ce) I can't reproduce the problem. > > dmesg with the panic and bisect log attached. > > [1] https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Paolo, can you please take a look at this? -- Jens Axboe