Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 53ABC615B0
Subject: Re: [PATCH] rcu: tree_stall: Correctly unlock root node in
 rcu_check_gp_start_stall
To:     Mukesh Ojha <mojha@codeaurora.org>, paulmck@linux.vnet.ibm.com,
        josh@joshtriplett.org, rostedt@goodmis.org,
        mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
        joel@joelfernandes.org
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1553858828-23097-1-git-send-email-neeraju@codeaurora.org>
 <7a9eed5a-9bcf-460c-abb9-1e9bd6eae102@codeaurora.org>
From:   Neeraj Upadhyay <neeraju@codeaurora.org>
Message-ID: <2a8057f7-0704-5e8f-423e-e56a91a9b448@codeaurora.org>
Date:   Fri, 29 Mar 2019 19:52:15 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <7a9eed5a-9bcf-460c-abb9-1e9bd6eae102@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/29/19 6:58 PM, Mukesh Ojha wrote:
> 
> On 3/29/2019 4:57 PM, Neeraj Upadhyay wrote:
>> Only unlock the root node, if current node (rnp) is not
>> root node.
>>
>> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
> 
> 
> 
>> ---
>>   kernel/rcu/tree_stall.h | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
>> index f65a73a..0651833 100644
>> --- a/kernel/rcu/tree_stall.h
>> +++ b/kernel/rcu/tree_stall.h
> 
> 
> why this is showing as under tree_stall.h while it is under 
> "kernel/rcu/tree.c"

It's moved in 
https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?h=dev&id=10462d6f58fb6dbde7563e9343505d98d5bfba3d

Please see linux-rcu dev tree for other changes, which moves code to 
this file.


Thanks
Neeraj

> 
>> @@ -630,7 +630,9 @@ static void rcu_check_gp_start_stall(struct 
>> rcu_node *rnp, struct rcu_data *rdp,
>>           time_before(j, rcu_state.gp_req_activity + gpssdelay) ||
>>           time_before(j, rcu_state.gp_activity + gpssdelay) ||
>>           atomic_xchg(&warned, 1)) {
>> -        raw_spin_unlock_rcu_node(rnp_root); /* irqs remain disabled. */
>> +        if (rnp_root != rnp)
>> +            /* irqs remain disabled. */
>> +            raw_spin_unlock_rcu_node(rnp_root);
> 
> Looks good as it will balance the lock .if it is the root_node, which 
> was not there earlier, and unlock was happening without any lock on root.
> 
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
> 
> Cheers,
> -Mukesh
> 
>>           raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
>>           return;
>>       }

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation