Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1663475ybb; Fri, 29 Mar 2019 08:50:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxfDp0EPVhmvz5UDmyZE1Lug9WxET9yEyHdcointpiPVbfh+p3ID939I9kSUpnJraxYuMmC X-Received: by 2002:a65:620e:: with SMTP id d14mr46645358pgv.28.1553874619357; Fri, 29 Mar 2019 08:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553874619; cv=none; d=google.com; s=arc-20160816; b=HE3CKuPje/LTxAPh/aTWtlNkcZ6vnIvR1WKv0X6XxsRRCzuQ56lBvmNQ5mxTzszhyS rvA0krNbhfkZ/1ndoGvctnqPK+S36IvQg2sEZ6m0RVOhuQk2S//ah6SUhRh5uJIjewBt 2q/jT74sZ6y/CPOH/OJDGiojnaiAZdSwSroncN9aYAp3ujSE1xgIRxAf3rONER0/YATi nJDJtF4EvGi8nTR+LCkAbpbG3kPd0Jl8bGNweKSoiYLgMZSqlxILMuMPUqb6vYPJVQ1C ZV0soUQF1/hr3lSvL9fWKnALqw0DEZHZFCo9rJ8c7s172cFSNeEbaJW+Wfx81WgKf3j8 1oNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:to :from; bh=ZTK6Vlk8Zu2Uae4v0Z0o4IszeoryHYw0APZHLQaYxcg=; b=E3KjvtQsgMKSzu6UfX/rbsKrOZsGgAhOeugJUfKqfBo+57mfYIKTHSd0QlP4/+tD1p FwnRleAf5yNsxHLkT0rPDq3EDHaAKt0/xtdkOtpcH8Xt8egQHJBP8xigMd3uZAiOcbVQ 2/y4vIaIA2EZJtAJ5LYAvUJRBzWg7cp/CVz4UAt3lcOx84EkUNyFPVldO5G0afZzuGNP tsx5wBt1PScn2LS1NazVHY8RPe3vVGLhNSyB4g1k6PsvurGWSSQ4lPop6F4y25w/eNR4 P+a18PABmvENyGHzA59MLWEkoP2Dol5QtE8NMgCQYt8tI+wPx442PNASS3cQ/Tn9q1mV oCKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si2152321pge.14.2019.03.29.08.50.03; Fri, 29 Mar 2019 08:50:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729646AbfC2PtU (ORCPT + 99 others); Fri, 29 Mar 2019 11:49:20 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:11451 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728936AbfC2PtU (ORCPT ); Fri, 29 Mar 2019 11:49:20 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2TFg09x016019; Fri, 29 Mar 2019 16:49:11 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2rddhc5v4e-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 29 Mar 2019 16:49:11 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 33BEA31; Fri, 29 Mar 2019 15:49:11 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas21.st.com [10.75.90.44]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0ED624ED4; Fri, 29 Mar 2019 15:49:11 +0000 (GMT) Received: from SAFEX1HUBCAS23.st.com (10.75.90.47) by SAFEX1HUBCAS21.st.com (10.75.90.44) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 29 Mar 2019 16:49:11 +0100 Received: from localhost (10.201.23.97) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.435.0; Fri, 29 Mar 2019 16:49:10 +0100 From: =?UTF-8?q?Yannick=20Fertr=C3=A9?= To: Yannick Fertre , Philippe Cornu , Vincent Abriou , David Airlie , Daniel Vetter , Maxime Coquelin , Alexandre Torgue , , , , Subject: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages Date: Fri, 29 Mar 2019 16:49:08 +0100 Message-ID: <1553874548-31366-1-git-send-email-yannick.fertre@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.97] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-29_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Cornu Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better inform the user in case of fifo underruns or transfer errors. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/ltdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index b1741a9..15d8a02 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane, mutex_lock(&ldev->err_lock); if (ldev->error_status & ISR_FUIF) { - DRM_DEBUG_DRIVER("Fifo underrun\n"); + DRM_WARN("ltdc fifo underrun: please verify display mode\n"); ldev->error_status &= ~ISR_FUIF; } if (ldev->error_status & ISR_TERRIF) { - DRM_DEBUG_DRIVER("Transfer error\n"); + DRM_WARN("ltdc transfer error\n"); ldev->error_status &= ~ISR_TERRIF; } mutex_unlock(&ldev->err_lock); -- 2.7.4