Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190325194220.5873-1-helgaas@kernel.org> <4faf234df19c1b54b70cbe82c0dacacc58568b87.camel@perches.com>
In-Reply-To: <4faf234df19c1b54b70cbe82c0dacacc58568b87.camel@perches.com>
From:   Bjorn Helgaas <bhelgaas@google.com>
Date:   Fri, 29 Mar 2019 12:03:11 -0500
Message-ID: <CAErSpo7bGn8JP9n6UaPUdTJ1ZFonnZX+C+bCFgfN4HH2Hu6OpA@mail.gmail.com>
Subject: Re: [PATCH] vfio: Use dev_printk() when possible
To:     Joe Perches <joe@perches.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        kvm@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 3:49 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2019-03-25 at 14:42 -0500, Bjorn Helgaas wrote:
> > Use dev_printk() when possible to make messages consistent with other
> > device-related messages.
>
> trivial note:
>
> > diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> []
> > @@ -89,7 +89,8 @@ static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)
> >       } while ((pcs_value & MDIO_CTRL1_RESET) && --count);
> >
> >       if (pcs_value & MDIO_CTRL1_RESET)
> > -             pr_warn("%s XGBE PHY reset timeout\n", __func__);
> > +             dev_warn(&vdev->device, "%s XGBE PHY reset timeout\n",
> > +                      __func__);
>
> Many of these could use a colon after the %s used with __func__
> to make the output more consistent with other modules.

Thanks, Joe.  I added a colon to the two in
vfio_platform_amdxgbe_reset().  Those were the only ones I saw, except
for a couple "%s failed" messages in
drivers/vfio/vfio_iommu_spapr_tce.c, which I didn't change because (1)
they can't use dev_err() so slightly out of scope for this patch, and
(2) it arguably reads more naturally without the colon.

In vfio_pci.c, I converted some pr_info() to dev_info() without adding
a dev_fmt definition, so that removed the KBUILD_MODNAME prefix, which
I didn't intend.  I'll add "#define dev_fmt pr_fmt" to restore the
prefix.

Messages from drivers/vfio use a variety of prefixes (none, "VFIO: ",
KBUILD_MODNAME, __func__).  That could potentially be rationalized but
I would want Alex's guidance first.

Bjorn