Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1758499ybb; Fri, 29 Mar 2019 10:41:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxsvkEhpr8fEvw5WAqh1h2ci6ivYuwoKgy/T8YHy9x0Rn4X/5wcP/Fsyj6qrfWjiyBog0fe X-Received: by 2002:a17:902:2aa6:: with SMTP id j35mr49734960plb.56.1553881310375; Fri, 29 Mar 2019 10:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553881310; cv=none; d=google.com; s=arc-20160816; b=IPthhVhwpl8MfvuIDvJIAuYgzaAjuWfO6zqTdxkPrzQH9YM7G/vVcaG4oI0dp0SQbc crHfEyUGQMSGflO3MQyupt0k1zLJwjvuQv4JPtmMvwEsk9bOH4CMcTQYkrK0TXVfO92R P9jNTm5oyRct+bPj6CPC01jPcgDCMllJEn4YHrJbVmQ6WxJ2MPrgoR4x+/9/Nt+rHD+C 3rsz06i89TD594QHriVCLQ1ys78i4dsUEs6+SRZ+R6DepjytHPwfQzbtqCTJ3LN07is2 CwT8C2HLgv20f6z+mq/8sOfJpQ7HfAKXmiuBwmVaSxtXS6Lmtvkg5/rJEUnPxyYqIdDR P9dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=39Pp9Gq8OZ5NDRMhOnEFoLqEQPCUsHoMfjh9henmx/I=; b=eM8p+9KNxW6kf0Pih/kMH52WyRw/b1AXKpSuRzHGy7/VYU4RKCCShAqyaGP4eLLfBg 9Aythn2UkdgS2nVqjAqe6ESoVjZ5B153J+KOKiRWm3QHdwvGpaRzRKSHevJJS5M6d0qZ A7tWqxvvaJLCJsInnUmv6BqrnENex0yD/3QZcKR2F05ELnClp3KBaMyOviJP/3DjFCXu mVw74ISWNknZpIraOXXbSIyKhRuybBkbxGSCk4KoE5B5SvBuOISbxXMjFXZSEKU2FE0k ssDIqV4jNKJZHIlEEcDyjS0ozw5kge/ZdQjxad1slK1IiVSh4KVXlUw3REjaXqdEQhoN rutQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14si2214373pff.76.2019.03.29.10.41.34; Fri, 29 Mar 2019 10:41:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729902AbfC2Rkt (ORCPT + 99 others); Fri, 29 Mar 2019 13:40:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:44698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729842AbfC2Rkt (ORCPT ); Fri, 29 Mar 2019 13:40:49 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36DB521871; Fri, 29 Mar 2019 17:40:47 +0000 (UTC) Date: Fri, 29 Mar 2019 13:40:45 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Linux List Kernel Mailing , Ingo Molnar , Andrew Morton , Andy Lutomirski , Roland McGrath , Oleg Nesterov , linux-arch , Peter Zijlstra , Thomas Gleixner , "Gustavo A. R. Silva" , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , Dominik Brodowski , Andy Lutomirski , Kees Cook , "Eric W. Biederman" , "Dmitry V. Levin" Subject: Re: [RFC][PATCH 0/4 v2] sycalls: Remove args i and n from syscall_get_arguments() Message-ID: <20190329134045.3fb2e69f@gandalf.local.home> In-Reply-To: References: <20190328230512.486297455@goodmis.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Mar 2019 10:24:58 -0700 Linus Torvalds wrote: > The whole series looks fine to me. Great! I may just send a pull request to you, after some fixes (see below). > > I still suspect that we should just remove the syscall_set_arguments() > thing entirely, but even without that, the cleanup of the calling > convention is at least an improvement. I'll keep it around for now, but this should go as a warning to Dmitry, to get something using it soon, or they may be dropped. Also, Dmitry found a few bugs with the current syscall_set/get_arguments() on some of the archs (riscv and csky). Which I'll add at the front of this series and update my changes to keep the same logic. Then I'll post a non RFC version. -- Steve