Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp1786824ybb; Fri, 29 Mar 2019 11:17:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3nBJVfpnn37U3q55ielVwGnh66Yoq57IzHA3bszdQ/hdMPYerBYlxuP7oT+XrWZSA4+9t X-Received: by 2002:a62:6f06:: with SMTP id k6mr48086878pfc.257.1553883449135; Fri, 29 Mar 2019 11:17:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553883449; cv=none; d=google.com; s=arc-20160816; b=sV9zVZ0env1+Oe32hq8bgxCJ++rSc+nuD5p08/v+lJ8GvYy/RZZfrlb6xxcdE+5WvD K9a/vil7q6XfAj+80KA1KnL/1hZVFm+JZLrJF231/eAx8jFqmfFZXxqfzJ0MDP17SnAX nMLrXpkJ98Z4JljRWzTr5cKZH1IBNunZqyM3kadFSorYfumhINrf14zE7QaPkqfPggUw 5LU4RLAiPDjwabA0hve6FV0WYQ4W+cJwGZbF7QFJwq7CQ3So7Q9WBjsVNqoJ1JmxMMNb fuNaqdDe5zWwjTafgZAHfzijcOd9YK4kvJcUj5jPeQDsPiLC2DelMOinPyIG+akG0dVC q1Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=qLIkINGrRfzvHJYHOHMHmcxUZjEY6Ns4Nkzofb5gpgg=; b=xDag27a5Xi2T5emwIU5DVal9yKBb6ccMdoSmYe06KNpyjo3+D90FPCWzF6zqoJEFXN 0X4qk7A4vnBqnvglbFt+b+OphoPexGt02SRnZCZ7koP1fKZ3pzU5g+lnKReMTUbbAmCu LVA23D9PNPSe0iQV16zKeN96h2aavIY9h0v8sbmxVcYxv6JY24zp4Yq5HNR/x7yVbBYO 6PSb2fQEJqlXBT8NgPXM5p7TDiAgHqPnh4A2YEkXdGEExXF4yw3bdMQrtg+0QhL1AGvE Z86f8WfMyCeLCyErc0pHHwcHQI3D2ZMkA/qMZKmZ7zEM18Zy1FFQdKsw1JWyjEml4dfP C1ig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si2560037pln.403.2019.03.29.11.17.13; Fri, 29 Mar 2019 11:17:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729990AbfC2SQX (ORCPT + 99 others); Fri, 29 Mar 2019 14:16:23 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:58788 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729921AbfC2SQX (ORCPT ); Fri, 29 Mar 2019 14:16:23 -0400 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 0F77D72CCAD; Fri, 29 Mar 2019 21:16:20 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id F1DAB7CC74C; Fri, 29 Mar 2019 21:16:19 +0300 (MSK) Date: Fri, 29 Mar 2019 21:16:19 +0300 From: "Dmitry V. Levin" To: Steven Rostedt Cc: Guo Ren , Palmer Dabbelt , Ingo Molnar , Kees Cook , Andy Lutomirski , Will Drewry , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: fix syscall_get_arguments() and syscall_set_arguments() Message-ID: <20190329181619.GB32651@altlinux.org> References: <20190329171221.GA32456@altlinux.org> <20190329131514.3e4ec93e@gandalf.local.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="61jdw2sOBCFtR2d/" Content-Disposition: inline In-Reply-To: <20190329131514.3e4ec93e@gandalf.local.home> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --61jdw2sOBCFtR2d/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 29, 2019 at 01:15:14PM -0400, Steven Rostedt wrote: > On Fri, 29 Mar 2019 20:12:21 +0300 > "Dmitry V. Levin" wrote: >=20 > > RISC-V syscall arguments are located in orig_a0,a1..a5 fields > > of struct pt_regs. > >=20 > > Due to an off-by-one bug and a bug in pointer arithmetic > > syscall_get_arguments() was reading s3..s7 fields instead of a1..a5. > > Likewise, syscall_set_arguments() was writing s3..s7 fields > > instead of a1..a5. >=20 > Should I add this to my series? And then rebase on top of it? This is fine with me. If you are adding the fix for riscv, please consider adding the fix for csky, too. --=20 ldv --61jdw2sOBCFtR2d/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJcnmDzAAoJEAVFT+BVnCUIEwoQAJFU9YuwW0jEozEhXNul4GNR E1aMCIPrK/9OKouxQNBkQSRgE5bnbmvvSW5UBDKmJ+kzHXSTvZ2iOV5aPkng7Svk eVjeBnu8pdX3uNFpZ5WHDVfs+qr7oDuBZpdmK3h1RfxA9PBtwpg/SBOBXlGwCS+J vYn19hxasA5hJ3bXlBP0ssiQT0hTsqmTkIfD0QWtaPJq3lRXYYHt29CoEgXE6/qv Ju5XS/2pSH6Lt7JJQvT9BmcE7VIJI/T91mRS7CD8UfS2wyaNDV1r3/PMx2KF+nmN z/4MTFYXbVHKuxn8ljg6qUWhV4lEaKXInBuIKZN/LHmiuRxgTST6EoBYZrtYjr+O D6KyotRxjJR703YYrZmZq90Ms/nzshgU5OAeg6mdurmC6wYaf7Sm7WdcZv97HMJ1 FHxpy3zhtIuhif6riqolNqusOXFkhtADURXkSfNoJhiig4EWRxrcOml7+dzQN9Z1 QoVkx79yVTFeV8VbnxhYGR0OkSgmp/DOwa0jBJDCecTBs5lmkGe0WPNd5mYhQ/jw 0SevXWtSTbY9BEiTangFnkx1YuwyFybAHTzvgbVBoagWTbypZU3P57s+Sne5xNN/ MZ6EVNraPEbtimzLrXjvqKXgSHCgkmhzP0u3Z4ll1JRz6qA0jL5k43wwB6842+Ss XhK4Wa03+nTDpzzB4P1j =wm1N -----END PGP SIGNATURE----- --61jdw2sOBCFtR2d/--