Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jay Vosburgh <jay.vosburgh@canonical.com>
To:     Konstantin Khorenko <khorenko@virtuozzo.com>
cc:     Jarod Wilson <jarod@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Veaceslav Falico <vfalico@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] bonding: show full hw address in sysfs for slave entries
In-reply-to: <20190328102921.11680-1-khorenko@virtuozzo.com>
References: <20190328102921.11680-1-khorenko@virtuozzo.com>
Comments: In-reply-to Konstantin Khorenko <khorenko@virtuozzo.com>
   message dated "Thu, 28 Mar 2019 13:29:21 +0300."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4733.1553892205.1@famine>
Content-Transfer-Encoding: 8BIT
Date:   Fri, 29 Mar 2019 13:43:25 -0700
Message-ID: <4734.1553892205@famine>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Konstantin Khorenko <khorenko@virtuozzo.com> wrote:

>Bond expects ethernet hwaddr for its slave, but it can be longer than 6
>bytes - infiniband interface for example.
>
> # cat /sys/devices/<skipped>/net/ib0/address
> 80:00:02:08:fe:80:00:00:00:00:00:00:7c:fe:90:03:00:be:5d:e1
>
> # cat /sys/devices/<skipped>/net/ib0/bonding_slave/perm_hwaddr
> 80:00:02:08:fe:80
>
>So print full hwaddr in sysfs "bonding_slave/perm_hwaddr" as well.
>
>Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
>---
> drivers/net/bonding/bond_sysfs_slave.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
>index 2f120b2ffef0..4985268e2273 100644
>--- a/drivers/net/bonding/bond_sysfs_slave.c
>+++ b/drivers/net/bonding/bond_sysfs_slave.c
>@@ -55,7 +55,9 @@ static SLAVE_ATTR_RO(link_failure_count);
> 
> static ssize_t perm_hwaddr_show(struct slave *slave, char *buf)
> {
>-	return sprintf(buf, "%pM\n", slave->perm_hwaddr);
>+	return sprintf(buf, "%*phC\n",
>+		       slave->dev->addr_len,
>+		       slave->perm_hwaddr);
> }
> static SLAVE_ATTR_RO(perm_hwaddr);

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

	-J

---
	-Jay Vosburgh, jay.vosburgh@canonical.com