Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 76CDE60D35
Subject: Re: [PATCH] staging: rtl8723bs: core: fix line over 80 characters
 warning
To:     Anirudh Rayabharam <anirudh.rayabharam@gmail.com>,
        gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        hadess@hadess.net, hdegoede@redhat.com
Cc:     devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <20190326182309.GA33380@auvm>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <0ffd4bc1-bdc2-7e11-3309-ff6e7d3c206b@codeaurora.org>
Date:   Sat, 30 Mar 2019 02:46:41 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190326182309.GA33380@auvm>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/26/2019 11:55 PM, Anirudh Rayabharam wrote:
> Shorten the expression by re-using the part that was already computed to
> fix the line over 80 characters warning reported by checkpatch.pl.
>
> Signed-off-by: Anirudh Rayabharam <anirudh.rayabharam@gmail.com>
> ---
>   drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 18fabf5ff44b..bc0230672457 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -2336,8 +2336,8 @@ void rtw_ap_restore_network(struct adapter *padapter)
>   			Update_RA_Entry(padapter, psta);
>   			/* pairwise key */
>   			/* per sta pairwise key and settings */
> -			if ((padapter->securitypriv.dot11PrivacyAlgrthm == _TKIP_) ||
> -				(padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) {
> +			if ((psecuritypriv->dot11PrivacyAlgrthm == _TKIP_) ||
> +				(psecuritypriv->dot11PrivacyAlgrthm == _AES_)) {
>   				rtw_setstakey_cmd(padapter, psta, true, false);
>   			}


Get rid of this {}.fix this .

Now patch looks good after Dan comment.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

>   		}