Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <59cd9dd2381c029fe0ca81510f016e28ff906f18.camel@intel.com>
Subject: Re: [PATCH][next] iavf: iavf_client: use struct_size() helper
From:   Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        "David S. Miller" <davem@davemloft.net>
Cc:     intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 29 Mar 2019 15:37:33 -0700
In-Reply-To: <20190328203613.GA23692@embeddedor>
References: <20190328203613.GA23692@embeddedor>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-7wgFgYgg/nYQWXCZS0Xv"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-7wgFgYgg/nYQWXCZS0Xv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2019-03-28 at 15:36 -0500, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>=20
> struct foo {
>     int stuff;
>     struct boo entry[];
> };
>=20
> size =3D sizeof(struct foo) + count * sizeof(struct boo);
>=20
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
>=20
> size =3D struct_size(instance, entry, count);
>=20
> This code was detected with the help of Coccinelle.
>=20
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_client.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Thanks Gustavo, I will queue this up.

--=-7wgFgYgg/nYQWXCZS0Xv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlyeni0ACgkQ5W/vlVpL
7c7EGA//RGnOT5JHhRV4Srf3B6I09QLbkWJyaq5EVELHodEAsCgpkzuCRf2RFdA2
xNGsurdeOobCwfzLi2Th6s4hp9PhUVfjZrrMISGIgvNMcMHkejEtRSuuNV8y2Ell
xC8no004A2HqfOOH3MKXKxm6W+gAleRfKppsOMKfXHFxJlKUMevW3cLo+U53jKTe
evBufmhbbERakWQJtU/Xf4b/Tggt+wSMLFkjlUMcsl16MGzITP/NTtXhdpr9hPtN
vnnAnEmtRe19hDRzyx00Nr2GpwMG5cHPEsgUI3fIAQ8x7WT6J7UPATAsU17gPaGi
2u+v4C1ucLnu5cFgZxks2QeaKW9vUP2FAomY8Iv59x2COTypyozy7Umts7eao7fM
jnMlBbie0X7dJj/cBCnMqyaxIH4uG5PVZOpe4kaMgl2vlEqcITVRDYmM8vemot4c
xQ8WV0iMmPDBab6A/mBppGaRIgtQBbkv2X3dtKZsSYoQCBkKdma3g5lFvtSm3kxd
oX1eOuxieANEqcxfoYWYD9tI0d0kDBec4WFM9kGZokUKLoe/Sakt6YUNpy27AnO2
CRd1NXAWndPioLY96RnyODR+sO9ctFeBHeVxTOd8pgk3kNeh5APfmrjbnknM7S1M
YhQ9g8i2JSp13ECROwcN+XKhFAR5Gllb0jwvgc/8UDvNI/o5DX8=
=w+Fd
-----END PGP SIGNATURE-----

--=-7wgFgYgg/nYQWXCZS0Xv--