Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1553850324-25625-1-git-send-email-nixiaoming@huawei.com>
References: <1553850324-25625-1-git-send-email-nixiaoming@huawei.com>
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH] clk:Fix divide by 0 error in divider_ro_round_rate_parent
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To:     jbrunet@baylibre.com, mturquette@baylibre.com,
        nixiaoming@huawei.com, rnayak@ti.com, sboyd@codeaurora.org,
        soren.brinkmann@xilinx.com
Message-ID: <155389932276.20095.12054188967513679921@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Fri, 29 Mar 2019 15:42:02 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting nixiaoming (2019-03-29 02:05:24)
> In the function divider_recalc_rate The judgment of the return value of

Please write divider_recalc_rate() with parenthesis to show it's a
function.

> _get_div indicates that the return value of _get_div may be 0.

__get_div()

> In order to avoid the divide-by-zero error, add check the return value
> of _get_div in the divider_ro_round_rate_parent
>=20
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>

Is this your name? nixiaoming? Or is it written some other way?

> ---
>  drivers/clk/clk-divider.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> index e5a1726..0854e3e 100644
> --- a/drivers/clk/clk-divider.c
> +++ b/drivers/clk/clk-divider.c
> @@ -347,6 +347,8 @@ long divider_ro_round_rate_parent(struct clk_hw *hw, =
struct clk_hw *parent,
>         int div;
> =20
>         div =3D _get_div(table, val, flags, width);
> +       if (!div) /* avoid divide-by-zero */
> +               return -EINVAL;

How does _get_div() return 0? What is the value of 'flags' here when
this goes wrong?

> =20
>         /* Even a read-only clock can propagate a rate change */
>         if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {
> --=20
> 1.8.5.6
>=20

Wow that's a 5 year old version of git!