Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1553859960-31501-1-git-send-email-nixiaoming@huawei.com>
References: <1553859960-31501-1-git-send-email-nixiaoming@huawei.com>
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH] clk:mmp: clk-mix.c fix divide-by-zero
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To:     chao.xie@marvell.com, mturquette@baylibre.com,
        nixiaoming@huawei.com
Message-ID: <155389969479.20095.682832622477946593@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Fri, 29 Mar 2019 15:48:14 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting nixiaoming (2019-03-29 04:46:00)
> The _get_div function has a branch with a return value of 0
> Add a check on the return value of _get_div to avoid divide-by-zero
>=20
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>

Similar questions apply here as they do on the generic divider patch you
sent.

> ---
>  drivers/clk/mmp/clk-mix.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c
> index 90814b2..9d152c2 100644
> --- a/drivers/clk/mmp/clk-mix.c
> +++ b/drivers/clk/mmp/clk-mix.c
> @@ -245,6 +245,8 @@ static int mmp_clk_mix_determine_rate(struct clk_hw *=
hw,
>                         div_val_max =3D _get_maxdiv(mix);
>                         for (j =3D 0; j < div_val_max; j++) {
>                                 div =3D _get_div(mix, j);
> +                               if (!div) /* avoid divide-by-zero */

Why can't we return 1 for the divider value here?

> +                                       continue;
>                                 mix_rate =3D parent_rate / div;
>                                 gap =3D abs(mix_rate - req->rate);
>                                 if (!parent_best || gap < gap_best) {
> @@ -341,6 +343,8 @@ static unsigned long mmp_clk_mix_recalc_rate(struct c=
lk_hw *hw,
>         shift =3D mix->reg_info.shift_div;
> =20
>         div =3D _get_div(mix, MMP_CLK_BITS_GET_VAL(mux_div, width, shift)=
);
> +       if (!div) /* avoid divide-by-zero */

Same question.

> +               return -EINVAL;
> =20
>         return parent_rate / div;
>  }