Date: Sun, 28 Mar 2004 22:53:22 -0800
From: Andrew Morton <akpm@osdl.org>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.6.5-rc2 __WAITQUEUE_INITIALIZER
Message-Id: <20040328225322.05ac9f7b.akpm@osdl.org>
In-Reply-To: <5648.1080539353@kao2.melbourne.sgi.com>
References: <5648.1080539353@kao2.melbourne.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 929
Lines: 23

Keith Owens <kaos@ocs.com.au> wrote:
>
> When struct __wait_queue is on stack or you reuse an existing
> waitqueue, you get garbage in the flags.
> 
> Index: 5-rc2.1/include/linux/wait.h
> --- 5-rc2.1/include/linux/wait.h Thu, 18 Dec 2003 16:46:13 +1100 kaos (linux-2.6/m/c/34_wait.h 1.1 644)
> +++ 5-rc2.1(w)/include/linux/wait.h Mon, 29 Mar 2004 15:36:39 +1000 kaos (linux-2.6/m/c/34_wait.h 1.1 644)
> @@ -40,6 +40,7 @@ typedef struct __wait_queue_head wait_qu
>   */
>  
>  #define __WAITQUEUE_INITIALIZER(name, tsk) {				\
> +	.flags		= 0,						\
>  	.task		= tsk,						\
>  	.func		= default_wake_function,			\
>  	.task_list	= { NULL, NULL } }

The compiler will do this for us?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/