Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 78A516087D
Subject: Re: [PATCH v2 1/2] clk:Fix divide-by-zero in
 divider_ro_round_rate_parent
To:     nixiaoming <nixiaoming@huawei.com>, jbrunet@baylibre.com,
        mturquette@baylibre.com, sboyd@codeaurora.org,
        soren.brinkmann@xilinx.com
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1553913085-51237-1-git-send-email-nixiaoming@huawei.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <fcbcceb2-e59b-465a-ec36-cde354425898@codeaurora.org>
Date:   Sat, 30 Mar 2019 15:14:10 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1553913085-51237-1-git-send-email-nixiaoming@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/30/2019 8:01 AM, nixiaoming wrote:
> In the function divider_recalc_rate() The judgment of the return value of
> _get_div() indicates that the return value of _get_div() may be 0.

s/may be/can be


> In order to avoid the divide-by-zero error, add check the return values.
s/add check the/add check for

> of _get_div() in the divider_ro_round_rate_parent()
>
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>


Please fix the commit text.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/clk/clk-divider.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> index e5a1726..f4bf7a4 100644
> --- a/drivers/clk/clk-divider.c
> +++ b/drivers/clk/clk-divider.c
> @@ -347,6 +347,9 @@ long divider_ro_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent,
>   	int div;
>   
>   	div = _get_div(table, val, flags, width);
> +	/* avoid divide-by-zero */
> +	if (!div)
> +		return -EINVAL;
>   
>   	/* Even a read-only clock can propagate a rate change */
>   	if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {