Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8B5016087A
Subject: Re: [PATCH -next] crypto: marvell - remove set but not used variable
 'index'
To:     Yue Haibing <yuehaibing@huawei.com>, bbrezillon@kernel.org,
        arno@natisbad.org, herbert@gondor.apana.org.au, davem@davemloft.net
Cc:     linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
References: <20190330052858.24128-1-yuehaibing@huawei.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <cd033699-1660-a92e-08ec-0bdfa3113428@codeaurora.org>
Date:   Sat, 30 Mar 2019 15:45:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190330052858.24128-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/30/2019 10:58 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/crypto/marvell/hash.c: In function 'mv_cesa_ahash_pad_req':
> drivers/crypto/marvell/hash.c:138:15: warning: variable 'index' set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/crypto/marvell/hash.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c
> index 99ff54c..fd456dd 100644
> --- a/drivers/crypto/marvell/hash.c
> +++ b/drivers/crypto/marvell/hash.c
> @@ -135,11 +135,10 @@ static int mv_cesa_ahash_pad_len(struct mv_cesa_ahash_req *creq)
>   
>   static int mv_cesa_ahash_pad_req(struct mv_cesa_ahash_req *creq, u8 *buf)
>   {
> -	unsigned int index, padlen;
> +	unsigned int padlen;
>   
>   	buf[0] = 0x80;
>   	/* Pad out to 56 mod 64 */
> -	index = creq->len & CESA_HASH_BLOCK_SIZE_MSK;
>   	padlen = mv_cesa_ahash_pad_len(creq);
>   	memset(buf + 1, 0, padlen - 1);
>