Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp16231yba; Sat, 30 Mar 2019 13:15:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzO9/K3w+znMkoJG7fSIXS0kiu67PArdaTF0SIaRV8k9Adp4FiIldxmtkAoY7N10Ssq8mDD X-Received: by 2002:a63:945:: with SMTP id 66mr20105159pgj.128.1553976919374; Sat, 30 Mar 2019 13:15:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553976919; cv=none; d=google.com; s=arc-20160816; b=rcsvOesaXI/PBEju2Zm2vx75LBpaxfhnVrcQTLcQDBSCLDa098fZLxWrrsD5mZMHUa 912C1BA9OouOz9Vz/ZJfZk84hNjyf3KoW4ilQMTeTMk3yAHL2HcYZXUpMhAOrSOuZABJ tWqATHVmjWpHL6C14e/FvLukMpfNslxAI3p/j9RLK5gVIcgI3z6faqkp2cpKJMETk0nM uIyIerNqXS+nPO9i2rripTTHj3NTfTLlGKBzaqtCOpz3611LkxhTTdbCA4y10LVwEHvF zSPVZRzUfF8e8/N6Xp0lYfxk5k8rgQIPfXnNX7H4XDSmBkVu8sel1Lztp+X5ddX0Cl9T fvVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Hu1yObP1igScdYtzDA1EQ2bC0kZo279vyYlzSY4J+Rc=; b=yOXcQipLsPzWjaCbdzybPy1QNf2/25YUYtzC6ydJu7vC6/teX5wprrMqskHTU7uRRa IL0ghZGLB96OlLLbD/QeGb/uxuyOXTavMLRUmRBxgsmKTQBIEy2hrG5rLB160cP9dcD+ QK6QFWpkwfjasIMG0dVD+keE4JOhv0oWsTf1iRJBqsXT/PBdN3gPrlDacgz4+XcO7jhW y8sBRjdga7Kik+yT2KR4xDC6rVMjk/pTl1W8+8tcOjW4MHGEp0dggsz2+UzEB6Zgsl7h oQmeC6h6HXfxqBgVf+w3WCKw0hrytsohldlKI8HvU5d+kSWGF+RKRIBWItNaAO1EtJ+E 1tFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o10si5281287pfa.285.2019.03.30.13.15.03; Sat, 30 Mar 2019 13:15:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731019AbfC3UO2 (ORCPT + 99 others); Sat, 30 Mar 2019 16:14:28 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57173 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730851AbfC3UO2 (ORCPT ); Sat, 30 Mar 2019 16:14:28 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hAKMx-0007Gx-15; Sat, 30 Mar 2019 20:14:23 +0000 From: Colin King To: Stanislaw Gruszka , Kalle Valo , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iwlegacy: remove redundant assignment to *res Date: Sat, 30 Mar 2019 20:14:22 +0000 Message-Id: <20190330201422.8024-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Currently 1 is being assigned to *res and then it is immediately updated with the computed result. The first assignment is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/net/wireless/intel/iwlegacy/4965.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c index ce4144a89217..a20b6c885047 100644 --- a/drivers/net/wireless/intel/iwlegacy/4965.c +++ b/drivers/net/wireless/intel/iwlegacy/4965.c @@ -577,7 +577,6 @@ il4965_math_div_round(s32 num, s32 denom, s32 * res) sign = -sign; denom = -denom; } - *res = 1; *res = ((num * 2 + denom) / (denom * 2)) * sign; return 1; -- 2.20.1