Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp28576yba; Sat, 30 Mar 2019 13:39:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJksIorm/rxWYfMIiWmUzfprqgYZthkOFqvgXFOicMK9JKF6T7nAcdGwURfp7V3dBpf1VY X-Received: by 2002:a62:e213:: with SMTP id a19mr8740784pfi.85.1553978378172; Sat, 30 Mar 2019 13:39:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553978378; cv=none; d=google.com; s=arc-20160816; b=YZDxfRY7QkqbsmF3Du4BCbABWI9tUUNmQ5WwCL9Oqql/ATtV5pbJpMxmkVus23KeuQ MMLsMzafI6amPu4Up6RWaRtYN7CQKG6i+jcC+Zp4s6B213ZfaDK4Wwn2f+XYeiYWXUbh hE13G1ImFo7r6t8Lwxb4OpG+l2nVYqE82AAISxfbbCH7RGisTqaYEaBnY0X4UXVSOOvj R5/B1X7tewjEqPCFgGbvZpdY17nsroDXFt557ZYi42+M7a3+TJojneZ0Zshw/FeQ2P/h RhKbaqCEsBJ3PRXSLTgUmVBrHIBBp3Z306JFoV6JhvZYXg6Q9rvAcvo4JTs5pmBDC7Pm HCGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=P4hQ5ad1hYg7+BlW/pD859ZvBXwixUD3DERcOkcmRx8=; b=AxGJLfhZOHivEPJotkmJ+M8iAuwvFxXAJ0HLARtTGScHpEXr1ZALUh8pCZa3vJtI64 5+3Bc32MDrOx07TFNqXwJt+8Ib+ApIr+v4naYcqR2t2G+xDH4aegU9aTbxc1xnGto/2Q D5oLG9qrw/ApVQ8jiFm8Km4WE2QHeInjybO1LoKrdNHQmPDY/HwOk40kd2v4ID6gtE8c r1pLX/uLbklCENXXrno3GxtwTqA0gDBnHVDPFxGyHnIH53oZHHV6fT5p+xWNY1nMmRFm zRGI8LIJiVNpWopei2SmDSqR9BLsIGBm9emxL1Js2gn3tVaAaxO/PyiDcBlr9EDrvcxX oGHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x15si5403331pgi.524.2019.03.30.13.39.09; Sat, 30 Mar 2019 13:39:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730675AbfC3UiA (ORCPT + 99 others); Sat, 30 Mar 2019 16:38:00 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57326 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730589AbfC3UiA (ORCPT ); Sat, 30 Mar 2019 16:38:00 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hAKjl-0000VY-Do; Sat, 30 Mar 2019 20:37:57 +0000 From: Colin King To: Jan-Simon Moeller , Jacek Anaszewski , Pavel Machek , linux-leds@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr Date: Sat, 30 Mar 2019 20:37:57 +0000 Message-Id: <20190330203757.8877-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Currently data->i2c_addr is being assigned twice, first with the value 0x09 and then immediately afterwards with the value 0x08. The first assignment is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/leds/leds-blinkm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c index 851c1920b63c..11b771fb933b 100644 --- a/drivers/leds/leds-blinkm.c +++ b/drivers/leds/leds-blinkm.c @@ -594,7 +594,6 @@ static int blinkm_probe(struct i2c_client *client, goto exit; } - data->i2c_addr = 0x09; data->i2c_addr = 0x08; /* i2c addr - use fake addr of 0x08 initially (real is 0x09) */ data->fw_ver = 0xfe; -- 2.20.1