Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <8b6afee25fe6d2248353015fe2303d793b2a1d49.camel@perches.com>
Subject: Re: [greybus-dev] [PATCH] Staging: greybus: usb: Fixed a coding
 style error
From:   Joe Perches <joe@perches.com>
To:     Alex Elder <elder@linaro.org>,
        Will Cunningham <wjcunningham7@gmail.com>, johan@kernel.org
Cc:     devel@driverdev.osuosl.org, elder@kernel.org,
        linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Date:   Sat, 30 Mar 2019 23:40:28 -0700
In-Reply-To: <5c95c177-b8fe-ab0b-eb7a-d270e35a7ce6@linaro.org>
References: <20190331053040.GA12974@titus.pi.local>
         <41750e16d14a967529d7cb5e315110ee5ccd313c.camel@perches.com>
         <5c95c177-b8fe-ab0b-eb7a-d270e35a7ce6@linaro.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2019-03-31 at 01:20 -0500, Alex Elder wrote:
> On 3/31/19 1:04 AM, Joe Perches wrote:
> > Blind adherence to 80 column limits leads to poor looking
> > code.  Especially with longish identifier lengths.
> I agree.  If it were me, I'd use a local variable.  For example:
> 
> 	struct greybus_descriptor_cport *cport_desc = gbphy_dev->cport_desc;
> 	...
> 	connection = gb_connection_create(gbphy_dev->bundle,
> 					  le16_to_cpu(cport_desc->id), NULL);
> 
> Or maybe better:
> 
> 	u16 cport_id = le16_to_cpu(gbphy_dev->cport_desc->id);
> 	...
> 	connection = gb_connection_create(gbphy_dev->bundle, cport_id, NULL);

True.

A possible negative though:

Temporaries that are only used once are sometimes
less readable as the declaration is supposed to be
done at an open brace and that could be relatively
far away from the set and use.