Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp429062yba; Sun, 31 Mar 2019 03:14:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAZDF26yeknXhHAWOyihEsr1+c/qktZIPD6i647sDklooAKIvES9eIEb2+hGcjmu0HIXZw X-Received: by 2002:a62:2687:: with SMTP id m129mr6803367pfm.204.1554027242505; Sun, 31 Mar 2019 03:14:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554027242; cv=none; d=google.com; s=arc-20160816; b=otkRvKaMfWCG6FMLxcQBb+Tj+4p5rcNiJ0pEzGnZhk6Kr/YioY4A8EX/4oR+Rhk7OW 6kA/CIg8+AqovWYUw+Qm6f7KXOkjpXVnC7/FxxmBHLYZtDJIkfaYPbw+NIVhIUahOO4O /Vnp1p5ycppLIRvbQRd3gf3WcynNieT6Das2Jdqxaoupp/Z2hVLk+WFQLORcy/bmWTKi kRrX8VdyVJ3KuZ9RbXhF1JjZyLOV7X986h49H8J7pPsaEtbv0DWmouUOsdG/nm7a/f6v 9uzKxEgoov+3L9sFhUtBvJ921c5hQKBtQqcvzEgIDOeFmNWEorPw3R8uOMIaVQOk3uOt BWUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=nC4MZcO2/96LlagjNw3qguIDQPTavN2/XXg0+H2VY3c=; b=ZYcZjYh4iwUIAu3sX7GN8MBRhteQpQ365F8mRdlxT2baRfsqR3CcCPOkrLjA+O+5Jx +zyWPYa4F+J/LKc8F9H8u9BFOGyZf5BJWHfSrKavZyVoDYybiAdCh6TQnjYu55fZHXuG c8TX7s4WlSc31WITxyk4JnR14M7BPkEyV/ODabhyzxRzfCJ17wb8Tw0ehZwxRhrHSIFY jdWri2S45ZrRyfAEKSNwOxwRZrS3CbQ+z5x7DQxSbl3o48qGFt64VygYC1swLKydRa6G LvmEz9W4r8g2tk8Dm06Yey8rXNiXRGQKGdTvk6ZS+GXqkupFk1ZcgO++61oFX/bd+5Xh Oxdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 136si6343605pfc.170.2019.03.31.03.13.46; Sun, 31 Mar 2019 03:14:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbfCaKNF (ORCPT + 99 others); Sun, 31 Mar 2019 06:13:05 -0400 Received: from ozlabs.org ([203.11.71.1]:52373 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbfCaKNE (ORCPT ); Sun, 31 Mar 2019 06:13:04 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 44XBB65zQyz9sRW; Sun, 31 Mar 2019 21:13:02 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: ce9afe08e71e3f7d64f337a6e932e50849230fc2 X-Patchwork-Hint: ignore In-Reply-To: <1552059204-18626-1-git-send-email-ego@linux.vnet.ibm.com> To: "Gautham R. Shenoy" , Michael Bringmann , Benjamin Herrenschmidt , Paul Mackerras , Vaidyanathan Srinivasan From: Michael Ellerman Cc: "Pavithra R. Prakash" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Gautham R. Shenoy" Subject: Re: pseries/energy: Use OF accessor functions to read ibm, drc-indexes Message-Id: <44XBB65zQyz9sRW@ozlabs.org> Date: Sun, 31 Mar 2019 21:13:02 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-03-08 at 15:33:24 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > In cpu_to_drc_index() in the case when FW_FEATURE_DRC_INFO is absent, > we currently use of_read_property() to obtain the pointer to the array > corresponding to the property "ibm,drc-indexes". The elements of this > array are of type __be32, but are accessed without any conversion to > the OS-endianness, which is buggy on a Little Endian OS. > > Fix this by using of_property_read_u32_index() accessor function to > safely read the elements of the array. > > Fixes: commit e83636ac3334 ("pseries/drc-info: Search DRC properties for CPU indexes") > Cc: #v4.16+ > Reported-by: Pavithra R. Prakash > Signed-off-by: Gautham R. Shenoy > Reviewed-by: Vaidyanathan Srinivasan Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/ce9afe08e71e3f7d64f337a6e932e508 cheers