Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B739760735
Subject: Re: [PATCH V2] arm/mach-at91/pm : fix possible object reference leak
To:     Peng Hao <peng.hao2@zte.com.cn>, ludovic.desroches@microchip.com,
        nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <1554117631-108215-1-git-send-email-peng.hao2@zte.com.cn>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <7c01bd62-7aee-3a84-0af0-e07f1801b571@codeaurora.org>
Date:   Mon, 1 Apr 2019 12:36:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1554117631-108215-1-git-send-email-peng.hao2@zte.com.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/1/2019 4:50 PM, Peng Hao wrote:
> of_find_device_by_node() takes a reference to the struct device
> when it finds a match via get_device. When returning error we should
> call put_device.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>   arch/arm/mach-at91/pm.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 51e808a..b60fcc9 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -591,7 +591,7 @@ static int __init at91_pm_backup_init(void)
>   
>   	np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam");
>   	if (!np)
> -		goto securam_fail;
> +		goto securam_fail_1;
>   
>   	pdev = of_find_device_by_node(np);
>   	of_node_put(np);


I think you missed the label in

if (!pdev)

     goto securam_fail_1


Please fix that and also if possible give some proper name to the label.

Cheers,
Mukesh

> @@ -620,6 +620,8 @@ static int __init at91_pm_backup_init(void)
>   	return 0;
>   
>   securam_fail:
> +	put_device(&pdev->dev);
> +securam_fail_1:


>   	iounmap(pm_data.sfrbu);
>   	pm_data.sfrbu = NULL;
>   	return ret;