Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262873AbUC2OSH (ORCPT ); Mon, 29 Mar 2004 09:18:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262885AbUC2OSH (ORCPT ); Mon, 29 Mar 2004 09:18:07 -0500 Received: from ms-smtp-04.texas.rr.com ([24.93.47.43]:17885 "EHLO ms-smtp-04.texas.rr.com") by vger.kernel.org with ESMTP id S262873AbUC2OSC (ORCPT ); Mon, 29 Mar 2004 09:18:02 -0500 Date: Mon, 29 Mar 2004 08:17:56 -0600 From: Dan Hopper To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.5-rc2-mm4 Message-ID: <20040329141756.GA6367@yoda.dummynet> Mail-Followup-To: Dan Hopper , Andrew Morton , linux-kernel@vger.kernel.org References: <1E741-Sh-5@gated-at.bofh.it> <20040328235928.GA32243@obiwan.dummynet> <20040328164613.18316ab8.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040328164613.18316ab8.akpm@osdl.org> User-Agent: Mutt/1.5.5.1+cvs20040105i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2062 Lines: 56 Andrew Morton remarked: > Dan Hopper wrote: > > > > On a Thinkpad T40p, 2.6.5-rc2-mm4 does not boot successfully, > > whereas 2.6.5-rc2 does. All the typical things (ACPI, CPUFREQ, APIC > > & IOAPIC, etc.) are built in. The -mm4 kernel config was derived > > from the working config for 2.6.5-rc2. > > > > I have to pass the nolapic kernel option to disable the local APIC > > in order to successfully boot 2.6.x kernels. It appears that with > > 2.6.5-rc2-mm4, this option is ignored, or perhaps there's a ordering > > issue with when it is checked. With -mm4, a message saying that it > > is enabling the local APIC appears _before_ the "Kernel command > > line: ... nolapic" line appears. > > > > Without the -mm4 patch, the nolapic command line option is parsed > > before it would have tried to reenable the local APIC. With -mm4, > > it is parsed after it tries to renable it. Boom, and then it locks > > on "Calibrating delay loop...". > > > > Any relevant config options I should try with/without to help narrow > > it down? > > Does this fix it? Yep, it sure does. Thanks! Dan > > --- > > 25-akpm/arch/i386/kernel/apic.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > diff -puN arch/i386/kernel/apic.c~early-param-i386-nolapic-fix arch/i386/kernel/apic.c > --- 25/arch/i386/kernel/apic.c~early-param-i386-nolapic-fix 2004-03-28 16:41:06.685335888 -0800 > +++ 25-akpm/arch/i386/kernel/apic.c 2004-03-28 16:42:17.299600888 -0800 > @@ -616,7 +616,7 @@ static int __init lapic_disable(char *st > clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability); > return 0; > } > -__setup("nolapic", lapic_disable); > +__early_param("nolapic", lapic_disable); > > static int __init lapic_enable(char *str) > { > > _ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/