Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553602674-531-1-git-send-email-mojha@codeaurora.org>
In-Reply-To: <1553602674-531-1-git-send-email-mojha@codeaurora.org>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Mon, 1 Apr 2019 08:25:40 +0100
Message-ID: <CA+V-a8tXq2CjZ+LmOzyg_Jr9Mc0MevjYBFfQ+FJwsW+UDd60_g@mail.gmail.com>
Subject: Re: [PATCH] media: vpss: fix the order of resource clean up
To:     Mukesh Ojha <mojha@codeaurora.org>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 26, 2019 at 12:18 PM Mukesh Ojha <mojha@codeaurora.org> wrote:
>
> Clean up of resources should be in reverse order of vpss_init().
> Fix this inside vpss_exit().
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> ---
>  drivers/media/platform/davinci/vpss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

> diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c
> index 19cf685..e380fd3 100644
> --- a/drivers/media/platform/davinci/vpss.c
> +++ b/drivers/media/platform/davinci/vpss.c
> @@ -507,9 +507,9 @@ static int vpss_resume(struct device *dev)
>
>  static void vpss_exit(void)
>  {
> +       platform_driver_unregister(&vpss_driver);
>         iounmap(oper_cfg.vpss_regs_base2);
>         release_mem_region(VPSS_CLK_CTRL, 4);
> -       platform_driver_unregister(&vpss_driver);
>  }
>
>  static int __init vpss_init(void)
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
> Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>