Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jan Kotas <jank@cadence.com>
To:     Rob Herring <robh@kernel.org>
CC:     Jan Kotas <jank@cadence.com>, Mark Rutland <mark.rutland@arm.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "pedrom.sousa@synopsys.com" <pedrom.sousa@synopsys.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: scsi: ufs-cdns: Update Cadence UFS
 compatibility list
Thread-Topic: [PATCH 1/2] dt-bindings: scsi: ufs-cdns: Update Cadence UFS
 compatibility list
Thread-Index: AQHU5Ku7sYTkHASvFkidSwhS/GGDG6YlUJEAgAGk74A=
Date:   Mon, 1 Apr 2019 07:49:24 +0000
Message-ID: <BEE57023-51AA-4513-929E-00855D282DB9@global.cadence.com>
References: <20190327144405.5716-1-jank@cadence.com>
 <20190327144405.5716-2-jank@cadence.com> <20190331025745.GA28612@bogus>
In-Reply-To: <20190331025745.GA28612@bogus>
Accept-Language: en-US, pl-PL
Content-Language: en-US
received-spf: None (protection.outlook.com: cadence.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <58C45F487B911442824B33EEA05EF36E@namprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c1b4b90-4b44-429a-de38-08d6b6768f40
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2019 07:49:24.4662
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2443
X-Proofpoint-SPF-Result: pass
X-Proofpoint-SPF-Record: v=spf1 include:_spf.salesforce.com include:mktomail.com
 include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com
 include:auth.msgapp.com include:spf.mandrillapp.com ~all
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-01_04:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1904010058
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On 31 Mar 2019, at 08:42, Rob Herring <robh@kernel.org> wrote:
>=20
> On Wed, Mar 27, 2019 at 02:44:04PM +0000, Jan Kotas wrote:
>> This patch adds a new compatible string description for
>> CDNS UFS HCD + M31 16nm PHY.
>=20
> The phy is not a separate block?=20

In this case PHY is controlled by some extra registers
in the controller's address space, accessible via its
hardware register interface.

Having an extra compatible also makes it consistent with
others controllers, which are already in the kernel.

ufs-qcom.txt:
- compatible        : compatible list, contains one of the following -
			"qcom,ufs-phy-qmp-20nm" for 20nm ufs phy,
			"qcom,ufs-phy-qmp-14nm" for legacy 14nm ufs phy,
			"qcom,msm8996-ufs-phy-qmp-14nm" for 14nm ufs phy
			 present on MSM8996 chipset.

tc-dwc-g210-pltfrm.txt:
- compatible	: compatible list must contain the PHY type & version:
			"snps,g210-tc-6.00-20bit"
			"snps,g210-tc-6.00-40bit"

Regards,
Jan

>=20
>>=20
>> Signed-off-by: Jan Kotas <jank@cadence.com>
>> ---
>> Documentation/devicetree/bindings/ufs/cdns,ufshc.txt | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>=20
>> diff --git a/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt b/Docu=
mentation/devicetree/bindings/ufs/cdns,ufshc.txt
>> index a04a4989e..02347b017 100644
>> --- a/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt
>> +++ b/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt
>> @@ -5,8 +5,9 @@ Each UFS controller instance should have its own node.
>> Please see the ufshcd-pltfrm.txt for a list of all available properties.
>>=20
>> Required properties:
>> -- compatible	: Compatible list, contains the following controller:
>> -			"cdns,ufshc"
>> +- compatible	: Compatible list, contains one of the following controlle=
rs:
>> +			"cdns,ufshc" - Generic CDNS HCI,
>> +			"cdns,ufshc-m31-16nm" - CDNS UFS HC + M31 16nm PHY
>> 		  complemented with the JEDEC version:
>> 			"jedec,ufs-2.0"
>>=20
>> --=20
>> 2.15.0
>>=20
>=20