Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7ED9C602FC
Subject: Re: [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to
 simplify code
To:     Anson Huang <anson.huang@nxp.com>,
        "a.zummo@towertech.it" <a.zummo@towertech.it>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     dl-linux-imx <linux-imx@nxp.com>
References: <1554096271-17921-1-git-send-email-Anson.Huang@nxp.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <8a485ab9-435f-4dfc-1e3d-4dc97e95376a@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:27:20 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1554096271-17921-1-git-send-email-Anson.Huang@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/1/2019 10:59 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>   drivers/rtc/rtc-snvs.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
> index ce73eab..e0edd594 100644
> --- a/drivers/rtc/rtc-snvs.c
> +++ b/drivers/rtc/rtc-snvs.c
> @@ -272,7 +272,6 @@ static const struct regmap_config snvs_rtc_config = {
>   static int snvs_rtc_probe(struct platform_device *pdev)
>   {
>   	struct snvs_rtc_data *data;
> -	struct resource *res;
>   	int ret;
>   	void __iomem *mmio;
>   
> @@ -284,9 +283,8 @@ static int snvs_rtc_probe(struct platform_device *pdev)
>   
>   	if (IS_ERR(data->regmap)) {
>   		dev_warn(&pdev->dev, "snvs rtc: you use old dts file, please update it\n");
> -		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>   
Remove this blank line.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> -		mmio = devm_ioremap_resource(&pdev->dev, res);
> +		mmio = devm_platform_ioremap_resource(pdev, 0);
>   		if (IS_ERR(mmio))
>   			return PTR_ERR(mmio);
>