Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp46224yba; Mon, 1 Apr 2019 01:14:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxapsoQl2DuanpysY2lB8uC+TLeOlF0faRXt+8aso1sshH3+K8iMtZVsE8a3sEGjyOTPAZ8 X-Received: by 2002:a17:902:e109:: with SMTP id cc9mr10169650plb.148.1554106459918; Mon, 01 Apr 2019 01:14:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554106459; cv=none; d=google.com; s=arc-20160816; b=eB8eTfVkTqrpghCNZ61syp3YWUQejNzvGQmoIN4PAS/LNAcB+DO964bL0ivZQ+xdpp zGXDZrTFXsIOGnQW1iGyZBAfRapQeluArWN/9M3fv+eb5TaSM2aeBI02xGdy2JvYetXV EQ14cR3Yg17MM6FUKzkVaxJaqr3LQrr1EndGYxMrfdmHr1IA2j07Vil/lousAyl5gnpn A8hyU58Q8fCVjyuvwXYpX401Vb+xeQFMTnJd6xSELlvMREnKoQKYTCXX9JgEWMMeVBHx 3VmQ5RfLOd56udooNwgOmIr+QoTIAkOC+ZEy3UKtZhzamMHLZ5KSHrGaAxauS17KDlbt 5sfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature; bh=jcv20GR+fMwb56uRQokTuisvLl20lzn+7yYNUhFLrCk=; b=ptinm3koRxw1u1LTzgk/uFvins6haWNMskHfTouv+102Sm1wZXyEGFNQo/CJeDJ4kd 8Z70JFwWERkVyWnq/Le90y3aDTfN5sVevkac0+2iovlUuXe8NP0LOojg05Eug0uEKjXZ tnnqT9HfQtaUzych6Q0TZdNJO/tBpV+Q4gdP49nRX5+xrNzpBlCeWy/ZTGya5yfAGErL 8ORWKOookEaafaeq+BuboPmFjZC8AykC+7q5QT5rkW1BShqWRjOt0hWfnzCzvl1Zrqw8 cu+MHEFyDRIjlDHXwUeQs7fkBSmasbWZIsUwJo7eiAC7zcWzSYWtw+CiSRYYVHGbOgpp y6TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=pJzHuBKl; dkim=pass header.i=@codeaurora.org header.s=default header.b=ddU5XWJb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r124si5559439pgr.201.2019.04.01.01.14.04; Mon, 01 Apr 2019 01:14:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=pJzHuBKl; dkim=pass header.i=@codeaurora.org header.s=default header.b=ddU5XWJb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732053AbfDAIMx (ORCPT + 99 others); Mon, 1 Apr 2019 04:12:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44332 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731889AbfDAIMx (ORCPT ); Mon, 1 Apr 2019 04:12:53 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3B2E261947; Mon, 1 Apr 2019 08:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554106372; bh=5KYfurn/5xQD7uJrc/lL/272OYc1sZHS0EsAVpIrEhE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=pJzHuBKlFZBV5LM63OiS77imekHD79/XMKSdWMFOlFylS9omwPzilNOSQ/423qzPu TEjFtLupwW7hvOZsQabYPC+NJQWMUu/UkIOgmoZiKm7ruX6plJCgjnE5JGWZTnyY0a wWe04hDAGENITNtoJEw7aNpblqNmD2g3yrb5tBKc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from [10.204.79.83] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 10D4061156; Mon, 1 Apr 2019 08:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554106367; bh=5KYfurn/5xQD7uJrc/lL/272OYc1sZHS0EsAVpIrEhE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ddU5XWJbbY2TQ5KJjTCYXrUjcbWhPihQM1as3dJjwK5DrKbywf1V3oMkMmywLAKHZ raeD6PRc5hdtqLNCowh4cQllXmu6NryaVVgbL+0HWCpIOnxR3ni3tvftY410pauG6x QxJfl13AOUAxx8rUYCCXlVvYRb/VH9+IDReuN5DI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 10D4061156 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH] watchdog: imx2_wdt: use devm_platform_ioremap_resource() to simplify code To: Anson Huang , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Cc: dl-linux-imx References: <1554094787-14766-1-git-send-email-Anson.Huang@nxp.com> From: Mukesh Ojha Message-ID: Date: Mon, 1 Apr 2019 13:42:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554094787-14766-1-git-send-email-Anson.Huang@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/2019 10:34 AM, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > drivers/watchdog/imx2_wdt.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c > index 2b52514..1b0faa2 100644 > --- a/drivers/watchdog/imx2_wdt.c > +++ b/drivers/watchdog/imx2_wdt.c > @@ -247,7 +247,6 @@ static int __init imx2_wdt_probe(struct platform_device *pdev) > { > struct imx2_wdt_device *wdev; > struct watchdog_device *wdog; > - struct resource *res; > void __iomem *base; > int ret; > u32 val; > @@ -256,8 +255,7 @@ static int __init imx2_wdt_probe(struct platform_device *pdev) > if (!wdev) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(&pdev->dev, res); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); >