Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E92E760A42
Subject: Re: [PATCH] iio: adc: ads124: avoid buffer overflow
To:     =?UTF-8?Q?Vincent_Stehl=c3=a9?= <vincent.stehle@laposte.net>,
        linux-iio@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
References: <20190331185423.11749-1-vincent.stehle@laposte.net>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <a133aeda-6477-0fd7-77b3-7a5383370f96@codeaurora.org>
Date:   Mon, 1 Apr 2019 14:02:34 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190331185423.11749-1-vincent.stehle@laposte.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/1/2019 12:24 AM, Vincent Stehlé wrote:
> When initializing the priv->data array starting from index 1, there is one
> less element to consider than when initializing the full array.
>
> Fixes: e717f8c6dfec8f76 ("iio: adc: Add the TI ads124s08 ADC code")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/iio/adc/ti-ads124s08.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
> index 53f17e4f2f230..552c2be8d87ad 100644
> --- a/drivers/iio/adc/ti-ads124s08.c
> +++ b/drivers/iio/adc/ti-ads124s08.c
> @@ -202,7 +202,7 @@ static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan)
>   	};
>   
>   	priv->data[0] = ADS124S08_CMD_RDATA;
> -	memset(&priv->data[1], ADS124S08_CMD_NOP, sizeof(priv->data));
> +	memset(&priv->data[1], ADS124S08_CMD_NOP, sizeof(priv->data) - 1);
>   
>   	ret = spi_sync_transfer(priv->spi, t, ARRAY_SIZE(t));
>   	if (ret < 0)