Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] dccp: Fix memleak in __feat_register_sp
To:     Mukesh Ojha <mojha@codeaurora.org>, <davem@davemloft.net>,
        <gerrit@erg.abdn.ac.uk>
References: <20190401013554.17488-1-yuehaibing@huawei.com>
 <4ad301d4-7af2-87e4-9b52-9c4eee09b79c@codeaurora.org>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <dccp@vger.kernel.org>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <2022d726-4785-5d64-c8b5-37171d2dc220@huawei.com>
Date:   Mon, 1 Apr 2019 16:44:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <4ad301d4-7af2-87e4-9b52-9c4eee09b79c@codeaurora.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/4/1 16:24, Mukesh Ojha wrote:
> 
> On 4/1/2019 7:05 AM, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> If dccp_feat_push_change fails, we forget free the mem
>> which is alloced by kmemdup in dccp_feat_clone_sp_val.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
>> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
> 
> 
> I don't think it is the first version. Do keep in mind to put detail here .

Yes, this is the v3 resend.

> 
> -Mukesh
> 
>>   net/dccp/feat.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/dccp/feat.c b/net/dccp/feat.c
>> index f227f00..db87d9f 100644
>> --- a/net/dccp/feat.c
>> +++ b/net/dccp/feat.c
>> @@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
>>       if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
>>           return -ENOMEM;
>>   -    return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
>> +    if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
>> +        kfree(fval.sp.vec);
>> +        return -ENOMEM;
>> +    }
>> +
>> +    return 0;
>>   }
>>     /**
> 
>