Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp72267yba; Mon, 1 Apr 2019 01:56:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwDcxPD1iWoXbjjFqvCFTeSrmWqrk6sjLyoXzime2eWYtBoBUqsaiUrcjIxU4UrsWNEKct6 X-Received: by 2002:a17:902:7081:: with SMTP id z1mr21780262plk.252.1554109009680; Mon, 01 Apr 2019 01:56:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554109009; cv=none; d=google.com; s=arc-20160816; b=sA1Ygp9y8i9gfXiYriqhJTA4P03ZL4hrwDmY4vrEmKaEk4wPlN94izDy+xCbGS2PCm khtoDBWKhj8fZT4gleH3XJVw6jTnc5QY7jrBCRoFdE+ibBkJKQ7p2F//zRERrNUxjfwp fCEC3QJ6MwqQthM9yfiOFw8MRL4v/e475iu+i6IfHGuAWLxO7aP3Rh09V/HtA6KreWbB CDdvlqGN/zvLyjbTQaUmi119ac9X8w7TX9WhP6ybKoK4uQV5mCna/5UroQyjNAxfntub M6FKC5xpLUhD86tiNjwVdc8BelO4D+NtIy0SOHIA3EXh6pEY1zANc8/d0LTmXj4TLxYE Uv5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=Aps3CS/+DAvmJ5xjjYVcIAk/ipvCguHMa4/6ao/+GS8=; b=RZ/XpXhKT6sv2JjrQxWDXKNYexIQdr4H8ttdZBzvcXhbHBsnv96cgcZDQcBGqmGRQD gf3DcdNWrpJxHPdrJl7OYo6fK+oDxxHAyRGtq5/UzFyszZ4x0XWicHsxlZXtmsTTC0no ALlHIQIRaxXrVCR1mFZ6kReD1MmPjNmJCIhGjV4y8y6II2jzo0/fGtDiGsHHXjzIM/Lg q0FyGlZPp3XtiYnRP2PQx37AXnhTjsZpaqY/chKyMpCvagHrMPMjIrn3cBhKQgyhjixj NNvn+KXHp85JzfmElwDmzPS/ytZUc5z4eznsV0xgFMvkFYATLauGMI9T8SpDewI9yziT zpKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o90si8394182pfi.161.2019.04.01.01.56.34; Mon, 01 Apr 2019 01:56:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728937AbfDAIzV (ORCPT + 99 others); Mon, 1 Apr 2019 04:55:21 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:51131 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728196AbfDAIzU (ORCPT ); Mon, 1 Apr 2019 04:55:20 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x318k8Fr005388; Mon, 1 Apr 2019 10:55:13 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rjee26xfy-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 01 Apr 2019 10:55:13 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6F8093D; Mon, 1 Apr 2019 08:55:12 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas22.st.com [10.75.90.92]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 34C791662; Mon, 1 Apr 2019 08:55:12 +0000 (GMT) Received: from SAFEX1HUBCAS23.st.com (10.75.90.47) by Safex1hubcas22.st.com (10.75.90.92) with Microsoft SMTP Server (TLS) id 14.3.361.1; Mon, 1 Apr 2019 10:55:12 +0200 Received: from localhost (10.201.23.19) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.435.0; Mon, 1 Apr 2019 10:55:10 +0200 From: Hugues Fruchet To: Alexandre Torgue , Mauro Carvalho Chehab , Hans Verkuil CC: , , , , Benjamin Gaignard , Yannick Fertre , Philippe CORNU , "Hugues Fruchet" Subject: [PATCH 2/2] media: stm32-dcmi: do not emit error trace in case of few overrun Date: Mon, 1 Apr 2019 10:55:00 +0200 Message-ID: <1554108900-30705-3-git-send-email-hugues.fruchet@st.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554108900-30705-1-git-send-email-hugues.fruchet@st.com> References: <1554108900-30705-1-git-send-email-hugues.fruchet@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.19] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-01_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Report overrun error only when it exceeds a given threshold. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c index 693415c..b63d57c 100644 --- a/drivers/media/platform/stm32/stm32-dcmi.c +++ b/drivers/media/platform/stm32/stm32-dcmi.c @@ -97,6 +97,8 @@ enum state { #define TIMEOUT_MS 1000 +#define OVERRUN_ERROR_THRESHOLD 3 + struct dcmi_graph_entity { struct device_node *node; @@ -446,11 +448,13 @@ static irqreturn_t dcmi_irq_thread(int irq, void *arg) spin_lock_irq(&dcmi->irqlock); - if ((dcmi->misr & IT_OVR) || (dcmi->misr & IT_ERR)) { - dcmi->errors_count++; - if (dcmi->misr & IT_OVR) - dcmi->overrun_count++; + if (dcmi->misr & IT_OVR) { + dcmi->overrun_count++; + if (dcmi->overrun_count > OVERRUN_ERROR_THRESHOLD) + dcmi->errors_count++; } + if (dcmi->misr & IT_ERR) + dcmi->errors_count++; if (dcmi->sd_format->fourcc == V4L2_PIX_FMT_JPEG && dcmi->misr & IT_FRAME) { -- 2.7.4