Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553156120-13851-1-git-send-email-yannick.fertre@st.com> <2ebfb124-08dc-4d5f-9e12-2afc5295c0f6@st.com>
In-Reply-To: <2ebfb124-08dc-4d5f-9e12-2afc5295c0f6@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Mon, 1 Apr 2019 11:07:25 +0200
Message-ID: <CA+M3ks6Pz2z7OLFDRa4BCFqYLtqo3o5h0+bCS+L45UzgnuM_qw@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: add sleep power management
To:     Philippe CORNU <philippe.cornu@st.com>
Cc:     Yannick FERTRE <yannick.fertre@st.com>,
        Vincent ABRIOU <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le mar. 26 mars 2019 =C3=A0 14:02, Philippe CORNU <philippe.cornu@st.com> a=
 =C3=A9crit :
>
> (+ Benjamin)
>
> Dear Yannick,
> Many thanks for your patch.
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>
> Dear Benjamin,
> May I ask you please to merge this patch + "drm/stm: dw_mipi_dsi-stm:
> add sleep power management" on drm-misc, if you agree of course and when
> you think it is the right time (next week?)
> Big thanks,

Applied on drm-misc-next.

Benjamin

>
> Philippe :-)
>
>
> On 3/21/19 9:15 AM, Yannick Fertr=C3=A9 wrote:
> > Implements system sleep power management ops.
> >
> > Signed-off-by: Yannick Fertr=C3=A9 <yannick.fertre@st.com>
> > ---
> >   drivers/gpu/drm/stm/drv.c  | 35 +++++++++++++++++++++++++++++++++++
> >   drivers/gpu/drm/stm/ltdc.c | 24 ++++++++++++++++++++++++
> >   drivers/gpu/drm/stm/ltdc.h |  3 +++
> >   3 files changed, 62 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
> > index 0a7f933..5834ef5 100644
> > --- a/drivers/gpu/drm/stm/drv.c
> > +++ b/drivers/gpu/drm/stm/drv.c
> > @@ -129,6 +129,40 @@ static void drv_unload(struct drm_device *ddev)
> >       drm_mode_config_cleanup(ddev);
> >   }
> >
> > +static __maybe_unused int drv_suspend(struct device *dev)
> > +{
> > +     struct drm_device *ddev =3D dev_get_drvdata(dev);
> > +     struct ltdc_device *ldev =3D ddev->dev_private;
> > +     struct drm_atomic_state *state;
> > +
> > +     drm_kms_helper_poll_disable(ddev);
> > +     state =3D drm_atomic_helper_suspend(ddev);
> > +     if (IS_ERR(state)) {
> > +             drm_kms_helper_poll_enable(ddev);
> > +             return PTR_ERR(state);
> > +     }
> > +     ldev->suspend_state =3D state;
> > +     ltdc_suspend(ddev);
> > +
> > +     return 0;
> > +}
> > +
> > +static __maybe_unused int drv_resume(struct device *dev)
> > +{
> > +     struct drm_device *ddev =3D dev_get_drvdata(dev);
> > +     struct ltdc_device *ldev =3D ddev->dev_private;
> > +
> > +     ltdc_resume(ddev);
> > +     drm_atomic_helper_resume(ddev, ldev->suspend_state);
> > +     drm_kms_helper_poll_enable(ddev);
> > +
> > +     return 0;
> > +}
> > +
> > +static const struct dev_pm_ops drv_pm_ops =3D {
> > +     SET_SYSTEM_SLEEP_PM_OPS(drv_suspend, drv_resume)
> > +};
> > +
> >   static int stm_drm_platform_probe(struct platform_device *pdev)
> >   {
> >       struct device *dev =3D &pdev->dev;
> > @@ -186,6 +220,7 @@ static struct platform_driver stm_drm_platform_driv=
er =3D {
> >       .driver =3D {
> >               .name =3D "stm32-display",
> >               .of_match_table =3D drv_dt_ids,
> > +             .pm =3D &drv_pm_ops,
> >       },
> >   };
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..32fd6a3 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -1062,6 +1062,30 @@ static int ltdc_get_caps(struct drm_device *ddev=
)
> >       return 0;
> >   }
> >
> > +void ltdc_suspend(struct drm_device *ddev)
> > +{
> > +     struct ltdc_device *ldev =3D ddev->dev_private;
> > +
> > +     DRM_DEBUG_DRIVER("\n");
> > +     clk_disable_unprepare(ldev->pixel_clk);
> > +}
> > +
> > +int ltdc_resume(struct drm_device *ddev)
> > +{
> > +     struct ltdc_device *ldev =3D ddev->dev_private;
> > +     int ret;
> > +
> > +     DRM_DEBUG_DRIVER("\n");
> > +
> > +     ret =3D clk_prepare_enable(ldev->pixel_clk);
> > +     if (ret) {
> > +             DRM_ERROR("failed to enable pixel clock (%d)\n", ret);
> > +             return ret;
> > +     }
> > +
> > +     return 0;
> > +}
> > +
> >   int ltdc_load(struct drm_device *ddev)
> >   {
> >       struct platform_device *pdev =3D to_platform_device(ddev->dev);
> > diff --git a/drivers/gpu/drm/stm/ltdc.h b/drivers/gpu/drm/stm/ltdc.h
> > index e46f477..a1ad0ae 100644
> > --- a/drivers/gpu/drm/stm/ltdc.h
> > +++ b/drivers/gpu/drm/stm/ltdc.h
> > @@ -36,6 +36,7 @@ struct ltdc_device {
> >       u32 error_status;
> >       u32 irq_status;
> >       struct fps_info plane_fpsi[LTDC_MAX_LAYER];
> > +     struct drm_atomic_state *suspend_state;
> >   };
> >
> >   bool ltdc_crtc_scanoutpos(struct drm_device *dev, unsigned int pipe,
> > @@ -45,5 +46,7 @@ bool ltdc_crtc_scanoutpos(struct drm_device *dev, uns=
igned int pipe,
> >
> >   int ltdc_load(struct drm_device *ddev);
> >   void ltdc_unload(struct drm_device *ddev);
> > +void ltdc_suspend(struct drm_device *ddev);
> > +int ltdc_resume(struct drm_device *ddev);
> >
> >   #endif
> >