Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp202087yba; Mon, 1 Apr 2019 04:54:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqynNurepH6oTp6M2sdQvTqr9HhbCYIFs92oKuXT7w+QPADP+vH0COyaxoJELvxYMEcUA9PM X-Received: by 2002:a65:6407:: with SMTP id a7mr16787777pgv.424.1554119643565; Mon, 01 Apr 2019 04:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554119643; cv=none; d=google.com; s=arc-20160816; b=dnYtHXhNkTZSj2mA4NichSTMqzWTcHxp4nJvz/gnaAM37ML1gn6tUhY0FCoVlSdL3a aXJcKMFupq5FwEn2aOI/2gf55v8UOoYFPHiFcraGOWrEmFcblsuAvDW3tNAddRun2Bc+ Yu6Y9VTq5B4X6Z1Y7dddtmW+EibzprI7L/X/bkeKsp5AV41gC9Nhxt7sszEWqP6ffuYo ulmp/1WWFEi6y3++GiyJjo50yH1lrXlcrL7xX1AUVrH0T9zyXRbJkXELbYOJYZf8V0kF EngjCls5Lwv3IcS0AzCHpx1+HY2uMQOaC12klfPp1xA2exgr83d3G0XKssIFDeRAS3T9 oTjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:cc:to:subject:dkim-signature:dkim-filter; bh=RNtK5s/1+hT9FQhdeQ9u9XOvN1y9ajSb03GLGKTVeTk=; b=HHhAP4q4VE08UqKClhGTjGNMojGWlnQXlCtK4M2o25e6+/24cxmJwL8MkKvONLciZr XCZtzFj9RYXHQu3sqM/pUvUllRsZBgMzJlFVbaNy+0vTvPMYyz/VAJII6rOlxvyhL6Sl zUBsg6hX4+szbGsn3EQVun60ZEuEy+1ToK0uqk6NRuUAWxoWatx0jlTf9DrK+uO+VoFt wHZR5iD0ZJt1/HKyiLmp3YybIvUAABj0VTl34cNBwrCxlmQoKreINeB9D85CYZJM3QRJ 3z8SofcabUo8W4wKtL0fS2yX/uT8pB8v0J6kLU1ZHDLXxeU+tQFUKlDEahaLRbMdh/HK LJ6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="Q9EShU1/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4si8588972pfj.16.2019.04.01.04.53.47; Mon, 01 Apr 2019 04:54:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="Q9EShU1/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbfDALwy (ORCPT + 99 others); Mon, 1 Apr 2019 07:52:54 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:57969 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbfDALwy (ORCPT ); Mon, 1 Apr 2019 07:52:54 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190401115253euoutp02708938ef0bad3a225f11e86624aaf9a6~RV4SRGWdX0974409744euoutp02c for ; Mon, 1 Apr 2019 11:52:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190401115253euoutp02708938ef0bad3a225f11e86624aaf9a6~RV4SRGWdX0974409744euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1554119573; bh=RNtK5s/1+hT9FQhdeQ9u9XOvN1y9ajSb03GLGKTVeTk=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=Q9EShU1/Pg+USk/TGQTRQiqrEhmgdFt8sIzZBfcn/GvbenLnKyLV6N2ikuFQCkuUd ulTYcG084MH0AsODiOTIuziu4Hf4Eqe0YRhTBWg2oWQ4BZV5PIL4gHUtJ8PkPpJst9 JU+5rFPBsFQaLsQ+Y158fK2tpts49gefKV0eRr7Y= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190401115252eucas1p270173d4bd60792a8c7567dabbd3c60d7~RV4RombgO0352203522eucas1p2l; Mon, 1 Apr 2019 11:52:52 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 40.2A.04377.49BF1AC5; Mon, 1 Apr 2019 12:52:52 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190401115251eucas1p212ba1a09a84efa0e03a2b45b62480949~RV4Q8D8MZ0352203522eucas1p2i; Mon, 1 Apr 2019 11:52:51 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190401115251eusmtrp25dcc13466ac33f4fcb6ddfd837f1ab93~RV4Q7fUF-1360413604eusmtrp2N; Mon, 1 Apr 2019 11:52:51 +0000 (GMT) X-AuditID: cbfec7f4-12dff70000001119-f6-5ca1fb94b2d8 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 62.E7.04140.39BF1AC5; Mon, 1 Apr 2019 12:52:51 +0100 (BST) Received: from [106.120.51.71] (unknown [106.120.51.71]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190401115251eusmtip1e75c88a7369d7c1a9a232e89ae8a1e7f~RV4QjVhSI1638216382eusmtip1d; Mon, 1 Apr 2019 11:52:51 +0000 (GMT) Subject: Re: [PATCH] video/macfb: Remove redundant code To: Geert Uytterhoeven , Finn Thain Cc: linux-m68k , DRI Development , Linux Fbdev development list , Linux Kernel Mailing List From: Bartlomiej Zolnierkiewicz Message-ID: <6fa80c4d-1f20-deb0-e254-74f0147f4a81@samsung.com> Date: Mon, 1 Apr 2019 13:52:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsWy7djPc7pTfi+MMfgyW9jiytf3bBYTe5ey WDy7tZfJ4kTfB1aLy7vmsFksf7KW2YHN49DhDkaP+93HmTxOtn5j8Xh28CGrx+dNcgGsUVw2 Kak5mWWpRfp2CVwZtxfvYyy4y1bx5tgPtgbGO6xdjJwcEgImEp2bPrJ3MXJxCAmsYJT41Dud CSQhJPCFUWLfMSGIxGdGiT2PDjLDdBxf0cIKkVjOKPF921tGiI63jBLnb1uA2MIC5hITVnSz gdgiAhESZ56vYwFpYBa4zyjxd+Z5dpAEm4CVxMT2VWDNvAJ2Ehe+7wbbwCKgIvFoYztQAweH KFBz/xl1iBJBiZMzn7CA2JwCgRKHb0wAe4FZQF5i+9s5zCDzJQQWsUvcWdoN9ZuLxNy999kh bGGJV8e3QNkyEv93zmeCaFgHdFDHC6ju7YwSyyf/Y4OospY4fPwiK8gVzAKaEut36UOEHSWm T3jDCBKWEOCTuPFWEOIIPolJ26YzQ4R5JTrahCCq1SQ2LNvABrO2a+dKaCB6SLw5eYhpAqPi LCSvzULyziyEvQsYmVcxiqeWFuempxYb5aWW6xUn5haX5qXrJefnbmIEJpjT/45/2cG460/S IUYBDkYlHt4KpoUxQqyJZcWVuYcYJTiYlUR4z/QviBHiTUmsrEotyo8vKs1JLT7EKM3BoiTO W83wIFpIID2xJDU7NbUgtQgmy8TBKdXA2H2tSu5AfJT8E93pH1jdGwxNfLgaUrSdsg+oCTiF XWBRFLF6U6+lenjm7rvd17KufTObsaA039iybP6hy8eWHGvbt27p9I3T/c0O1c07+GdnvfKD gg3LH8x04v207caK4kdnbHlvPH299ejkvaeNVlt48Xj0J6jxb9VQbgm8/nqF/xejpwUqNkos xRmJhlrMRcWJAIQdVWEsAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t/xu7qTfy+MMTjXp2dx5et7NouJvUtZ LJ7d2stkcaLvA6vF5V1z2CyWP1nL7MDmcehwB6PH/e7jTB4nW7+xeDw7+JDV4/MmuQDWKD2b ovzSklSFjPziElulaEMLIz1DSws9IxNLPUNj81grI1MlfTublNSczLLUIn27BL2M24v3MRbc Zat4c+wHWwPjHdYuRk4OCQETieMrWsBsIYGljBIz16h2MXIAxWUkjq8vgygRlvhzrYuti5EL qOQ1o8SnH/vYQRLCAuYSE1Z0s4HYIgIREs+XNzJBFP1mlNiw8gYjiMMscJ9R4s3BnywgVWwC VhIT21cxgti8AnYSF77vZgaxWQRUJB5tbAerEQWadOthBwtEjaDEyZlPwGxOgUCJwzcmgF3K LKAu8WfeJWYIW15i+9s5zBMYBWchaZmFpGwWkrIFjMyrGEVSS4tz03OLjfSKE3OLS/PS9ZLz czcxAmNn27GfW3Ywdr0LPsQowMGoxMNbwbQwRog1say4MvcQowQHs5II75n+BTFCvCmJlVWp RfnxRaU5qcWHGE2BnpjILCWanA+M67ySeENTQ3MLS0NzY3NjMwslcd7zBpVRQgLpiSWp2amp BalFMH1MHJxSDYwTcn8ft7/Ra/yW87OE0p44QUHtkHSxpmaf/6KeycmVe/l+MFfO2Rv+p/ra 1izdC+eW2Ej3FnvMvPdZ6eXz9ZaxIVPF9iseFLgzKaAnnDlTP3jj6qxp14xUvis8vxu13NLq osa811YLmRfv4brb32j4OOKNerTqUcMpyjE+4p97RQ9PLrpeqqDEUpyRaKjFXFScCABIfjTQ swIAAA== X-CMS-MailID: 20190401115251eucas1p212ba1a09a84efa0e03a2b45b62480949 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190215082549epcas4p1d0901964a98383cefc42cab0dfeee178 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190215082549epcas4p1d0901964a98383cefc42cab0dfeee178 References: <86a3eca8946cbeb648ddbe3ff67b983ece7498d8.1550182390.git.fthain@telegraphics.com.au> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/15/2019 09:25 AM, Geert Uytterhoeven wrote: > On Fri, Feb 15, 2019 at 3:19 AM Finn Thain wrote: >> The value of info->var.bits_per_pixel get checked in macfb_setcolreg(). >> Remove additional checks as they are redundant. >> >> macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct >> initializer. Remove redundant assignments. >> >> macfb_defined.bits_per_pixel, .width and .height all get assigned >> unconditionally. Remove redundant initializers. >> >> Cc: linux-m68k@lists.linux-m68k.org >> Tested-by: Stan Johnson >> Signed-off-by: Finn Thain > > Reviewed-by: Geert Uytterhoeven Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics