Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 1 Apr 2019 10:43:24 -0400 (EDT)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Suwan Kim <suwan.kim027@gmail.com>
cc:     mathias.nyman@linux.intel.com, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] usb: host: xhci: Support running urb giveback in
 tasklet context
In-Reply-To: <20190401141611.10087-1-suwan.kim027@gmail.com>
Message-ID: <Pine.LNX.4.44L0.1904011040570.1506-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 1 Apr 2019, Suwan Kim wrote:

> Patch "USB: HCD: support giveback of URB in tasklet context"[1]
> introduced giveback of urb in tasklet context. [1] This patch was
> applied to ehci but not xhci. [2] This patch significantly reduces
> the hard irq time of xhci. Especially for uvc driver, the hard irq
> including the uvc completion function runs quite long but applying
> this patch reduces the hard irq time of xhci.

Please read the kerneldoc for usb_submit_urb() and usb_kill_urb(), in 
particular, the parts that describe how isochronous URBs are treated.  
Can you guarantee that with this patch applied, xhci-hcd will continue 
to work as the kerneldoc describes?

Alan Stern