Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp358054yba; Mon, 1 Apr 2019 07:47:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyemsAQvv392kjw+wi0vKTzWaD78j8Zjs5vcXO1CGOUplMaMNNqVU5CPdTkwnB8C7przGHd X-Received: by 2002:a62:70c6:: with SMTP id l189mr10639175pfc.139.1554130075757; Mon, 01 Apr 2019 07:47:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554130075; cv=none; d=google.com; s=arc-20160816; b=mU3HaUS64nQ1DBWO+65s+MzgtFaJDLPd1cgYeFwM70SmUsFtiQSMu6eZ7A5u3WEa5o 9HoXykPmmNQID5o3rL4FDcAA4Vl6VqOZMkroEg2r8wBmJsdWqnHn67xgbaP8uiAW/CLV QM+YG6ZPE4D6LTBvjz8RU3ABz+qB9Ui03StajsOO6h4d26+z1aIfPbWpABxI3nGA9zn7 IsNMncvBZYhMlNcgJYlMd+UitxYEexbQjy1MRq1WaZfE4LOEOL6kQHVQJT485xIobq2R 4yDe6Y/vEEOYnZ8hzMjcjdwVSeCPVahChI3aRIS41UIAhxWbOwc8axIL1S5EV1Cb81aH C4pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=mER50wNJPisIWqjvlrOHPeYE2BfzqT5vbYKHGSVVwtM=; b=ConZq18GbIZ+qQ6I5Eoq8b37FOpJDeFPCu3DN3zfrv+/1DbAzCMhmM4KcnpPyS9pUl fmZJgayB3NCCoJPtYBbsrL3MX8zdBdKP+XHS9Xn76g2m1e5kV2wjSFUY6s6hmDCuCWf0 dT8J/C2bfWN4426cDgCNHFJGMyN9p/z/dB4XlW6tAz4nWkyrca4IkgZV4vBOoFWiyvoU I/7sdH+Ltc4u8/VgDi66NEud8M3DvvfFfCGoQ37jyzEODr4MitnkFUaFO5tPOBfcpwjN clX9W+NUYGP9bWV8vCKkKqcfaXbK1SOnoHwWwRDTyWIRD6ZjMcG5EWycKAMqhcz8zSO2 Vhvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v15si6432897pgn.296.2019.04.01.07.47.39; Mon, 01 Apr 2019 07:47:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728553AbfDAOq5 convert rfc822-to-8bit (ORCPT + 99 others); Mon, 1 Apr 2019 10:46:57 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:53099 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfDAOq4 (ORCPT ); Mon, 1 Apr 2019 10:46:56 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-209-_UCUwBC3ON-jk56l_yeMxw-1; Mon, 01 Apr 2019 15:46:50 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 1 Apr 2019 15:47:55 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Mon, 1 Apr 2019 15:47:55 +0100 From: David Laight To: "'gregkh@linuxfoundation.org'" , "Andrey Abramov" CC: George Spelvin , "adrian.hunter@intel.com" , "ard.biesheuvel@linaro.org" , "benh@kernel.crashing.org" , "bp@alien8.de" , "darrick.wong@oracle.com" , "dchinner@redhat.com" , "dedekind1@gmail.com" , "hpa@zytor.com" , "jlbec@evilplan.org" , "jpoimboe@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "mark@fasheh.com" , "mingo@redhat.com" , "mpe@ellerman.id.au" , "naveen.n.rao@linux.vnet.ibm.com" , "paulus@samba.org" , "richard@nod.at" , "tglx@linutronix.de" , "vgupta@synopsys.com" , "x86@kernel.org" Subject: RE: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in the swap function Thread-Topic: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in the swap function Thread-Index: AQHU57BB1hN4l4tmIUuL1+h9cp5f16YnYvDQ Date: Mon, 1 Apr 2019 14:47:55 +0000 Message-ID: References: <18626931553963861@sas1-b3ec53dbc12b.qloud-c.yandex.net> <20467491553964233@myt4-c0b480c282c8.qloud-c.yandex.net> <20190330183826.GB21828@kroah.com> <201903302015.x2UKFnSL003850@sdf.org> <20434561554015618@myt1-cd60b8ae9bb9.qloud-c.yandex.net> <20190331105412.GA9393@kroah.com> In-Reply-To: <20190331105412.GA9393@kroah.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: _UCUwBC3ON-jk56l_yeMxw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: gregkh@linuxfoundation.org > Sent: 31 March 2019 11:54 ... > Yes, "int" is a very nice variable for "size", you need to explain why > it is better to use size_t here please. Actually, on x86_64 you probably want 'unsigned int' to avoid the compiler having to generate a sign-extending register move if the value is ever used in a 64bit expression (eg an address calculation). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)